You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/18 02:50:35 UTC

[GitHub] [spark] LuciferYang opened a new pull request #35563: [SPARK-38246][SQL] Refactor `KVUtils` and add UTs related to RocksDB

LuciferYang opened a new pull request #35563:
URL: https://github.com/apache/spark/pull/35563


   ### What changes were proposed in this pull request?
   The main change of this pr as follows:
   
   1. Refactor `KVUtils` to let the `open` method can use the passed `conf` to construct the corresponding `KVStore`
   2. Use new `KVUtils#open` to add UTs related to RocksDB, the new UTs cover the scenarios `LevelDB` has tested.
   
   
   ### Why are the changes needed?
   Add more test scenarios related to `RocksDB`.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GA and add new UTs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #35563: [SPARK-38246][CORE][SQL][SS][WEBUI] Refactor `KVUtils` and add UTs related to RocksDB

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35563:
URL: https://github.com/apache/spark/pull/35563#issuecomment-1045804730


   thanks  @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #35563: [SPARK-38246][CORE][SQL][SS][WEBUI] Refactor `KVUtils` and add UTs related to RocksDB

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35563:
URL: https://github.com/apache/spark/pull/35563


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #35563: [SPARK-38246][CORE][SQL][SS][WEBUI] Refactor `KVUtils` and add UTs related to RocksDB

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35563:
URL: https://github.com/apache/spark/pull/35563#issuecomment-1043850670


   cc @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org