You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/04/08 07:00:31 UTC
Review Request 45919: Updates to NOTICE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45919/
-----------------------------------------------------------
Review request for geode, Joey McAllister, Swapnil Bawaskar, and Dan Smith.
Repository: geode
Description
-------
GEODE-914: Remove log4j from NOTICE
Commit 5342935d301a4026b289637885e9236414feeb78 cleaned up log4j
code so this no longer needs to be declared in NOTICE.
GEODE-914: Removed unnecessary declarations from NOTICE
Removed spring-petclinic, Apache MyFaces, and fastutil from
NOTICE. None of these project contain a NOTICE with content
that needs to be propagated.
GEODE-914: Reworked NOTICE for binary distribution
Update binary NOTICE to match changes to bundled jar files.
Diffs
-----
NOTICE 8e7485fe5d8da0548cdb7d4d958bb612ea2c501a
geode-assembly/src/main/dist/NOTICE ec14cdaf4677c47032bf4840eca9d07da7ef4475
Diff: https://reviews.apache.org/r/45919/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 45919: Updates to NOTICE
Posted by Joey McAllister <jm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45919/#review127849
-----------------------------------------------------------
Ship it!
Ship It!
- Joey McAllister
On April 8, 2016, 12:21 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45919/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 12:21 p.m.)
>
>
> Review request for geode, Joey McAllister, Swapnil Bawaskar, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-914: Remove log4j from NOTICE
>
> Commit 5342935d301a4026b289637885e9236414feeb78 cleaned up log4j
> code so this no longer needs to be declared in NOTICE.
>
> GEODE-914: Removed unnecessary declarations from NOTICE
>
> Removed spring-petclinic, Apache MyFaces, and fastutil from
> NOTICE. None of these project contain a NOTICE with content
> that needs to be propagated.
>
> GEODE-914: Reworked NOTICE for binary distribution
>
> Update binary NOTICE to match changes to bundled jar files.
>
>
> Diffs
> -----
>
> NOTICE 8e7485fe5d8da0548cdb7d4d958bb612ea2c501a
> geode-assembly/src/main/dist/NOTICE ec14cdaf4677c47032bf4840eca9d07da7ef4475
>
> Diff: https://reviews.apache.org/r/45919/diff/
>
>
> Testing
> -------
>
> I should point out the NOTICE was semi-mechanically generated by:
>
> 1) exploding the binary distribution
> 2) exploding the embedded archives, wars, and jars
> 3) concatenating the notice file (if any) from each dependency
>
> After that I removed duplicate entries and extraneous lines.
>
> Still to come: specific notices for geode-web, geode-web-api, geode-pulse as these generate war files that are distributed via maven.
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 45919: Updates to NOTICE
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45919/
-----------------------------------------------------------
(Updated April 8, 2016, 12:21 p.m.)
Review request for geode, Joey McAllister, Swapnil Bawaskar, and Dan Smith.
Repository: geode
Description
-------
GEODE-914: Remove log4j from NOTICE
Commit 5342935d301a4026b289637885e9236414feeb78 cleaned up log4j
code so this no longer needs to be declared in NOTICE.
GEODE-914: Removed unnecessary declarations from NOTICE
Removed spring-petclinic, Apache MyFaces, and fastutil from
NOTICE. None of these project contain a NOTICE with content
that needs to be propagated.
GEODE-914: Reworked NOTICE for binary distribution
Update binary NOTICE to match changes to bundled jar files.
Diffs
-----
NOTICE 8e7485fe5d8da0548cdb7d4d958bb612ea2c501a
geode-assembly/src/main/dist/NOTICE ec14cdaf4677c47032bf4840eca9d07da7ef4475
Diff: https://reviews.apache.org/r/45919/diff/
Testing (updated)
-------
I should point out the NOTICE was semi-mechanically generated by:
1) exploding the binary distribution
2) exploding the embedded archives, wars, and jars
3) concatenating the notice file (if any) from each dependency
After that I removed duplicate entries and extraneous lines.
Still to come: specific notices for geode-web, geode-web-api, geode-pulse as these generate war files that are distributed via maven.
Thanks,
Anthony Baker