You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/02/28 21:53:30 UTC

Review Request 72178: Converted sending operator API events to synchronous authorization.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72178/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-10057
    https://issues.apache.org/jira/browse/MESOS-10057


Repository: mesos


Description
-------

Now that `ObjectApprovers` are indefinitely valid, we can store
them in each Subscriber for its whole lifetime, instead of creating
them for each event sent to each subscriber.


Diffs
-----

  src/master/http.cpp 67572a3ffa15b6fbc23d2c2a202023ac9b18cdca 
  src/master/master.hpp f3239cd2efdad8a3391878c9e62c771673400372 
  src/master/master.cpp 3c621e44f15b820c5e4105da1cc19283323ff177 
  src/master/readonly_handler.cpp f9c000643d64c9e30849d0d56f329ae052ffd137 
  src/tests/api_tests.cpp 87550168d950f7c423c57627b0349d99b39881ca 


Diff: https://reviews.apache.org/r/72178/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Re: Review Request 72178: Converted sending operator API events to synchronous authorization.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72178/#review219702
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Feb. 28, 2020, 9:53 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72178/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2020, 9:53 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10057
>     https://issues.apache.org/jira/browse/MESOS-10057
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now that `ObjectApprovers` are indefinitely valid, we can store
> them in each Subscriber for its whole lifetime, instead of creating
> them for each event sent to each subscriber.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 67572a3ffa15b6fbc23d2c2a202023ac9b18cdca 
>   src/master/master.hpp f3239cd2efdad8a3391878c9e62c771673400372 
>   src/master/master.cpp 3c621e44f15b820c5e4105da1cc19283323ff177 
>   src/master/readonly_handler.cpp f9c000643d64c9e30849d0d56f329ae052ffd137 
>   src/tests/api_tests.cpp 87550168d950f7c423c57627b0349d99b39881ca 
> 
> 
> Diff: https://reviews.apache.org/r/72178/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>