You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/08/18 14:35:10 UTC

[GitHub] [solr] bszabo97 opened a new pull request #266: SOLR-15578 Add Support for HSTS Security Protocol

bszabo97 opened a new pull request #266:
URL: https://github.com/apache/solr/pull/266


   Change-Id: I5c87491bd875351e46774dc4ff5652deda6808c3
   
   https://issues.apache.org/jira/browse/SOLR-15578
   
   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Solr:
   
   * https://issues.apache.org/jira/projects/SOLR-15578
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * SOLR-####: <short description of problem or changes>
   
   SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   A committer raised the idea of a supporting HSTS protocol and I think it is a good idea. We can add it somewhat easily as an option.
   
   # Solution
   
   I edited the jetty.xml as an initial try to enable HSTS protocol. This makes it so it is enabled by default with a max-age of 31536000. Right now there is no way to edit this number or disable HSTS except for deleting it from jetty.xml.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] bszabo97 commented on pull request #266: SOLR-15578 Add Support for HSTS Security Protocol

Posted by GitBox <gi...@apache.org>.
bszabo97 commented on pull request #266:
URL: https://github.com/apache/solr/pull/266#issuecomment-937656753


   This PR is out-dated, created new one with tests in it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] bszabo97 closed pull request #266: SOLR-15578 Add Support for HSTS Security Protocol

Posted by GitBox <gi...@apache.org>.
bszabo97 closed pull request #266:
URL: https://github.com/apache/solr/pull/266


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] bszabo97 closed pull request #266: SOLR-15578 Add Support for HSTS Security Protocol

Posted by GitBox <gi...@apache.org>.
bszabo97 closed pull request #266:
URL: https://github.com/apache/solr/pull/266


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] bszabo97 commented on pull request #266: SOLR-15578 Add Support for HSTS Security Protocol

Posted by GitBox <gi...@apache.org>.
bszabo97 commented on pull request #266:
URL: https://github.com/apache/solr/pull/266#issuecomment-937656753


   This PR is out-dated, created new one with tests in it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org