[GitHub] [incubator-nuttx] anjiahao1 commented on a diff in pull request #6320: use rmutex inside of all repeated implementation

[GitBox <gi...@apache.org>]

anjiahao1 commented on code in PR #6320:
URL: https://github.com/apache/incubator-nuttx/pull/6320#discussion_r881408940


##########
libs/libc/netdb/lib_dnsinit.c:
##########
@@ -140,56 +137,24 @@ bool dns_initialize(void)
  * Name: dns_semtake
  *
  * Description:
- *   Take the DNS semaphore, ignoring errors due to the receipt of signals.
+ *   Take the DNS lock, ignoring errors due to the receipt of signals.
  *
  ****************************************************************************/
 
 void dns_semtake(void)

Review Comment:
   g_dns_lock is gloal



##########
net/route/net_fileroute.c:
##########
@@ -597,36 +593,10 @@ int net_routesize_ipv6(void)
 #ifdef CONFIG_ROUTE_IPv4_FILEROUTE
 int net_lockroute_ipv4(void)

Review Comment:
   is a globl



##########
libs/libc/modlib/modlib_registry.c:
##########
@@ -82,40 +68,7 @@ static FAR struct module_s *g_mod_registry;
 
 void modlib_registry_lock(void)

Review Comment:
   g_modlock is a globl 



##########
include/nuttx/mutex.h:
##########
@@ -29,13 +29,14 @@
 #include <errno.h>
 #include <assert.h>
 #include <unistd.h>
-#include <nuttx/sched.h>
 #include <nuttx/semaphore.h>

Review Comment:
   i do it ,but have a complie error about 
   ![image](https://user-images.githubusercontent.com/75056955/170224772-b3e105a0-d590-441e-aa05-1163b46477cd.png)
   



##########
fs/aio/aio_initialize.c:
##########
@@ -119,53 +117,12 @@ void aio_initialize(void)
 
 int aio_lock(void)

Review Comment:
   g_aio_lock is a global variable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org