You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by franz1981 <gi...@git.apache.org> on 2018/06/24 14:11:49 UTC
[GitHub] qpid-jms pull request #19: Save allocation of new promise on each writeAndFl...
GitHub user franz1981 opened a pull request:
https://github.com/apache/qpid-jms/pull/19
Save allocation of new promise on each writeAndFlush
Using a void promise on Netty writeAndFlush is possible to save
the allocation of a new one on each call.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/qpid-jms void_promise_write_and_flush
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-jms/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit 430edd24e8890654ad30acc5ea185614dcdae4cd
Author: Francesco Nigro <ni...@...>
Date: 2018-06-24T14:10:15Z
Save allocation of new promise on each writeAndFlush
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-jms issue #19: Save allocation of new promise on each writeAndFlush
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/qpid-jms/pull/19
The main source of this optimization is coming from http://normanmaurer.me/presentations/2014-facebook-eng-netty/slides.html#8.0
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-jms pull request #19: Save allocation of new promise on each writeAndFl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-jms/pull/19
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-jms issue #19: Save allocation of new promise on each writeAndFlush
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/qpid-jms/pull/19
I spent some time reviewing netty code and getting a handle on how this would change the current behavior. From what I can see this should be safe to apply. The tests all pass from a local checkout as well. I'd recommend creating a JIRA and updating the PR with the JIRA issue to link up the work done here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-jms issue #19: Save allocation of new promise on each writeAndFlush
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/qpid-jms/pull/19
@tabish121 @gemmellr I have rebased it in order to make this PR compatible with the last version :+1:
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org