You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by "Zhong, Yanghong" <nj...@126.com> on 2016/03/26 00:36:54 UTC
About the function of the "Refresh" button under tab "System"
Under tab “System”, there’s a “Refresh” button. At the first sight, my understanding is that kylin reads the configuration file “kylin.properties” and reset the cache. However, based on code, kylin just shows the cache contents. It seems this button is for the right side button “Set Config”. After we set or update a value for a configuration property, it only updates the cache without UI.
How about this?
After a property be updated by “Set Config”, the left TextArea’s contents be updated automatically.
After the “refresh” button clicked for “Server Config”, kylin loads contents from the configuration file “kylin.properties” and updates the UI.
Best regards,
Yanghong Zhong
yangzhong@ebay.com <ma...@ebay.com>
Re: About the function of the "Refresh" button under tab "System"
Posted by "Zhong, Yanghong" <nj...@126.com>.
I agree with the influence of clearing all the changes being made and the risk of reseting the configuration. Thanks.
> On Mar 26, 2016, at 11:07 PM, ShaoFeng Shi <sh...@apache.org> wrote:
>
> My suggestion is "don't make it too smart"; the configurations in
> kylin.properties should be static, which not intend to be updated often.
> Some configurations are very basic which impact on the whole system; it is
> not easy to dynamically change without a restart.
>
> You also need consider the cluster mode, as the "Refresh"/"Set" request is
> only sent to one REST server, to take effective all nodes need be
> notified/syncronized.
>
>
> 2016-03-26 20:15 GMT+08:00 hongbin ma <ma...@apache.org>:
>
>> On Sat, Mar 26, 2016 at 7:36 AM, Zhong, Yanghong <nju_zyh081251218@126.com
>>>
>> wrote:
>>
>>> After a property be updated by “Set Config”, the left TextArea’s contents
>>> be updated automatically.
>>>
>>
>> this looks great to me
>>
>>
>>
>>> After the “refresh” button clicked for “Server Config”, kylin loads
>>> contents from the configuration file “kylin.properties” and updates the
>> UI.
>>>
>>
>> I'm not sure if this looks intuitive to users. It makes it look like
>> "reset" config rather than "refresh" config. After all the changes made in
>> "Set config" is not persisted to the configuration file. A brutal reload
>> will clear all the changes being made.
>>
>>
>>
>> --
>> Regards,
>>
>> *Bin Mahone | 马洪宾*
>> Apache Kylin: http://kylin.io
>> Github: https://github.com/binmahone
>>
>
>
>
> --
> Best regards,
>
> Shaofeng Shi
Re: About the function of the "Refresh" button under tab "System"
Posted by ShaoFeng Shi <sh...@apache.org>.
My suggestion is "don't make it too smart"; the configurations in
kylin.properties should be static, which not intend to be updated often.
Some configurations are very basic which impact on the whole system; it is
not easy to dynamically change without a restart.
You also need consider the cluster mode, as the "Refresh"/"Set" request is
only sent to one REST server, to take effective all nodes need be
notified/syncronized.
2016-03-26 20:15 GMT+08:00 hongbin ma <ma...@apache.org>:
> On Sat, Mar 26, 2016 at 7:36 AM, Zhong, Yanghong <nju_zyh081251218@126.com
> >
> wrote:
>
> > After a property be updated by “Set Config”, the left TextArea’s contents
> > be updated automatically.
> >
>
> this looks great to me
>
>
>
> > After the “refresh” button clicked for “Server Config”, kylin loads
> > contents from the configuration file “kylin.properties” and updates the
> UI.
> >
>
> I'm not sure if this looks intuitive to users. It makes it look like
> "reset" config rather than "refresh" config. After all the changes made in
> "Set config" is not persisted to the configuration file. A brutal reload
> will clear all the changes being made.
>
>
>
> --
> Regards,
>
> *Bin Mahone | 马洪宾*
> Apache Kylin: http://kylin.io
> Github: https://github.com/binmahone
>
--
Best regards,
Shaofeng Shi
Re: About the function of the "Refresh" button under tab "System"
Posted by hongbin ma <ma...@apache.org>.
On Sat, Mar 26, 2016 at 7:36 AM, Zhong, Yanghong <nj...@126.com>
wrote:
> After a property be updated by “Set Config”, the left TextArea’s contents
> be updated automatically.
>
this looks great to me
> After the “refresh” button clicked for “Server Config”, kylin loads
> contents from the configuration file “kylin.properties” and updates the UI.
>
I'm not sure if this looks intuitive to users. It makes it look like
"reset" config rather than "refresh" config. After all the changes made in
"Set config" is not persisted to the configuration file. A brutal reload
will clear all the changes being made.
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone