You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/27 15:43:22 UTC

[GitHub] [trafficcontrol] ocket8888 commented on pull request #5886: Fix Docs spacing/indentation and RFC3339 time

ocket8888 commented on pull request #5886:
URL: https://github.com/apache/trafficcontrol/pull/5886#issuecomment-849739954


   > "An ISO-like format" is vague and does not accomplish the purpose of documentation, in this case, which is to allow a user to anticipate the date format.
   
   "an ISO-like format" is consistent with how that format is described throughout most of the documentation, though I agree it's overly vague.
   
   > The whitespace updates all look fine, so if you want, if you remove the RFC3339 time commit from the PR and throw it in a separate one for more discussion, I'll gladly merge the whitespace fixes.
   
   Both changes ought to be done, so I don't really care much about splitting them up, unless you're saying I should do that.
   
   Here's my first thought on improving that: change "an ISO-like format" to a link to a label in the API index section that describes the custom format in more detail, and also probably links to the format's GoDoc on go.pkg.dev.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org