You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/04/04 03:02:23 UTC
[GitHub] [dubbo-go] zouyx commented on a change in pull request #1130: fix reExporter bug when config-center {applicationName}.configurator data change
zouyx commented on a change in pull request #1130:
URL: https://github.com/apache/dubbo-go/pull/1130#discussion_r606737666
##########
File path: config/service_config.go
##########
@@ -249,17 +249,27 @@ func (c *ServiceConfig) Unexport() {
return
}
+ if !c.exported.CAS(true, false) {
+ return
+ }
+ if !c.unexported.CAS(false, true) {
+ return
Review comment:
Previous logic is always success, but now not.
If return without a flag, how can i know it is unexport successfully?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org