You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ab...@apache.org on 2017/02/09 20:10:00 UTC
[43/50] lucene-solr:jira/solr-9858: SOLR-10083: Fix instanceof check
in ConstDoubleSource.equals (Pushkar Raste via Christine Poerschke)
SOLR-10083: Fix instanceof check in ConstDoubleSource.equals (Pushkar Raste via Christine Poerschke)
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/c20853bf
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/c20853bf
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/c20853bf
Branch: refs/heads/jira/solr-9858
Commit: c20853bf098a7daaf243997241b633f9997950c5
Parents: 0e0821f
Author: Christine Poerschke <cp...@apache.org>
Authored: Wed Feb 8 17:18:02 2017 +0000
Committer: Christine Poerschke <cp...@apache.org>
Committed: Wed Feb 8 17:18:02 2017 +0000
----------------------------------------------------------------------
solr/CHANGES.txt | 2 ++
.../apache/solr/analytics/util/valuesource/ConstDoubleSource.java | 3 +--
2 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/c20853bf/solr/CHANGES.txt
----------------------------------------------------------------------
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 129d802..d6d9724 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -144,6 +144,8 @@ Bug Fixes
* SOLR-10049: Collection deletion leaves behind the snapshot metadata (Hrishikesh Gadre via yonik)
+* SOLR-10083: Fix instanceof check in ConstDoubleSource.equals (Pushkar Raste via Christine Poerschke)
+
Optimizations
----------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/c20853bf/solr/contrib/analytics/src/java/org/apache/solr/analytics/util/valuesource/ConstDoubleSource.java
----------------------------------------------------------------------
diff --git a/solr/contrib/analytics/src/java/org/apache/solr/analytics/util/valuesource/ConstDoubleSource.java b/solr/contrib/analytics/src/java/org/apache/solr/analytics/util/valuesource/ConstDoubleSource.java
index 80e8ed1..e0ebad6 100644
--- a/solr/contrib/analytics/src/java/org/apache/solr/analytics/util/valuesource/ConstDoubleSource.java
+++ b/solr/contrib/analytics/src/java/org/apache/solr/analytics/util/valuesource/ConstDoubleSource.java
@@ -23,7 +23,6 @@ import org.apache.lucene.index.LeafReaderContext;
import org.apache.lucene.queries.function.FunctionValues;
import org.apache.lucene.queries.function.docvalues.DoubleDocValues;
import org.apache.lucene.queries.function.valuesource.ConstNumberSource;
-import org.apache.lucene.queries.function.valuesource.ConstValueSource;
import org.apache.solr.analytics.util.AnalyticsParams;
/**
@@ -67,7 +66,7 @@ public class ConstDoubleSource extends ConstNumberSource {
@Override
public boolean equals(Object o) {
- if (!(o instanceof ConstValueSource)) return false;
+ if (!(o instanceof ConstDoubleSource)) return false;
ConstDoubleSource other = (ConstDoubleSource)o;
return this.constant == other.constant;
}