You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by ad...@apache.org on 2026/10/01 17:05:49 UTC

(fineract) branch develop updated (5f4b6a4f53 -> b56917ebd5)

This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


    from 5f4b6a4f53 Merge pull request #6556
     add bc528a402e FINERACT-2859: document the client payloads the server actually returns
     add 697549d80a FINERACT-2859: document the charge and accounting payloads the server actually returns
     add 4cd6b5ad75 FINERACT-2859: add feign helpers for the client, charge and accounting tests
     add 47c60f675b FINERACT-2859: migrate the client lifecycle, search and identifier tests to feign
     add 4cf61222dd FINERACT-2859: migrate the client charge, transaction and collateral tests to feign
     add 2ce918e0c7 FINERACT-2859: migrate NotesTest to feign
     add ae3e1993b0 FINERACT-2859: migrate the charge tests to feign
     add 61747ed7b5 FINERACT-2859: migrate the accounting rule, financial activity and provisioning tests to feign
     add 3b29fbbbce FINERACT-2859: migrate AccountingScenarioIntegrationTest to feign
     add e4f513ecb6 FINERACT-2859: remove the legacy helpers left without callers
     new b56917ebd5 Merge pull request #6516

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ...inancialActivityAccountsApiResourceSwagger.java |    6 +-
 .../charge/api/ChargesApiResourceSwagger.java      |   13 +
 .../fineract/portfolio/charge/data/ChargeData.java |    2 +
 .../accounts/api/AccountsApiResourceSwagger.java   |    4 +
 .../api/ClientChargesApiResourceSwagger.java       |    2 +
 .../api/ClientIdentifiersApiResourceSwagger.java   |   22 +-
 .../portfolio/client/api/ClientsApiResource.java   |    5 +-
 .../client/api/ClientsApiResourceSwagger.java      |   55 +-
 .../api/InternalClientInformationApiResource.java  |    8 +
 .../AccountingScenarioIntegrationTest.java         | 1295 ++++++++------------
 .../fineract/integrationtests/ChargesTest.java     |  383 ++----
 .../ClientAuditingIntegrationTest.java             |   87 +-
 .../ClientCollateralIntegrationTest.java           |   57 +-
 .../integrationtests/ClientExternalIdTest.java     |  133 +-
 .../integrationtests/ClientStatusChecker.java      |   39 -
 .../fineract/integrationtests/ClientTest.java      |  313 ++---
 ...ientUndoRejectAndWithdrawalIntegrationTest.java |  274 ++---
 .../CollateralProductIntegrationTest.java          |   33 +-
 .../FinancialActivityAccountsTest.java             |  111 +-
 .../accounting/AccountingRuleIntegrationTest.java  |   28 +-
 .../client/ClientIdentifierTest.java               |  163 +--
 .../integrationtests/client/ClientSearchTest.java  |  256 ++--
 .../client/ClientTransactionTest.java              |   71 +-
 .../integrationtests/client/NotesTest.java         |  316 ++---
 .../feign/helpers/ClientIdentifierCommandsApi.java |   73 ++
 .../client/feign/helpers/FeignChargesHelper.java   |   25 +
 .../client/feign/helpers/FeignClientHelper.java    |  195 +++
 .../client/feign/helpers/FeignCodeHelper.java      |   14 +
 .../feign/helpers/FeignCollateralHelper.java       |   23 +
 .../FeignFinancialActivityAccountHelper.java       |   28 +
 .../feign/helpers/FeignJournalEntryHelper.java     |   56 +-
 .../client/feign/helpers/FeignNoteHelper.java      |   64 +
 .../feign/helpers/FeignShareAccountHelper.java     |    6 +
 .../feign/modules/ChargeRequestBuilders.java       |   31 +
 .../feign/modules/ClientRequestBuilders.java       |   28 +
 .../client/feign/modules/ClientTestData.java       |   43 +
 .../integrationtests/common/ClientChargesTest.java |  126 +-
 .../integrationtests/common/ClientHelper.java      |  639 ----------
 .../ProvisioningCategoryDeleteIntegrationTest.java |   38 +-
 .../common/ProvisioningIntegrationTest.java        |  113 +-
 .../common/TaxComponentHelper.java                 |   38 -
 .../integrationtests/common/TaxGroupHelper.java    |   43 -
 .../common/accounting/AccountHelper.java           |   15 -
 .../accounting/FinancialActivityAccountHelper.java |   21 -
 .../common/accounting/JournalEntryHelper.java      |   44 -
 .../common/charges/ChargesHelper.java              |  196 ---
 .../fixeddeposit/FixedDepositAccountHelper.java    |    8 -
 .../RecurringDepositAccountHelper.java             |  658 ----------
 .../RecurringDepositAccountStatusChecker.java      |  108 --
 .../RecurringDepositProductHelper.java             |  520 --------
 .../common/savings/SavingsAccountHelper.java       |    9 -
 .../common/savings/SavingsProductHelper.java       |   15 -
 .../integrationtests/common/system/CodeHelper.java |   36 -
 53 files changed, 2181 insertions(+), 4708 deletions(-)
 create mode 100644 integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/ClientIdentifierCommandsApi.java
 create mode 100644 integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/FeignNoteHelper.java
 create mode 100644 integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/modules/ClientTestData.java
 delete mode 100644 integration-tests/src/test/java/org/apache/fineract/integrationtests/common/TaxComponentHelper.java
 delete mode 100644 integration-tests/src/test/java/org/apache/fineract/integrationtests/common/TaxGroupHelper.java
 delete mode 100644 integration-tests/src/test/java/org/apache/fineract/integrationtests/common/recurringdeposit/RecurringDepositAccountHelper.java
 delete mode 100644 integration-tests/src/test/java/org/apache/fineract/integrationtests/common/recurringdeposit/RecurringDepositAccountStatusChecker.java
 delete mode 100644 integration-tests/src/test/java/org/apache/fineract/integrationtests/common/recurringdeposit/RecurringDepositProductHelper.java


(fineract) 01/01: Merge pull request #6516

Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git

commit b56917ebd5253e8b69e865b75387bf3e9a2e0f99
Merge: 5f4b6a4f53 e4f513ecb6
Author: Adam Saghy <ad...@gmail.com>
AuthorDate: Thu Oct 1 18:05:42 2026 +0100

    Merge pull request #6516
    
    FINERACT-2859: migrate client charges accounting tests to feign

 ...inancialActivityAccountsApiResourceSwagger.java |    6 +-
 .../charge/api/ChargesApiResourceSwagger.java      |   13 +
 .../fineract/portfolio/charge/data/ChargeData.java |    2 +
 .../accounts/api/AccountsApiResourceSwagger.java   |    4 +
 .../api/ClientChargesApiResourceSwagger.java       |    2 +
 .../api/ClientIdentifiersApiResourceSwagger.java   |   22 +-
 .../portfolio/client/api/ClientsApiResource.java   |    5 +-
 .../client/api/ClientsApiResourceSwagger.java      |   55 +-
 .../api/InternalClientInformationApiResource.java  |    8 +
 .../AccountingScenarioIntegrationTest.java         | 1295 ++++++++------------
 .../fineract/integrationtests/ChargesTest.java     |  383 ++----
 .../ClientAuditingIntegrationTest.java             |   87 +-
 .../ClientCollateralIntegrationTest.java           |   57 +-
 .../integrationtests/ClientExternalIdTest.java     |  133 +-
 .../integrationtests/ClientStatusChecker.java      |   39 -
 .../fineract/integrationtests/ClientTest.java      |  313 ++---
 ...ientUndoRejectAndWithdrawalIntegrationTest.java |  274 ++---
 .../CollateralProductIntegrationTest.java          |   33 +-
 .../FinancialActivityAccountsTest.java             |  111 +-
 .../accounting/AccountingRuleIntegrationTest.java  |   28 +-
 .../client/ClientIdentifierTest.java               |  163 +--
 .../integrationtests/client/ClientSearchTest.java  |  256 ++--
 .../client/ClientTransactionTest.java              |   71 +-
 .../integrationtests/client/NotesTest.java         |  316 ++---
 .../feign/helpers/ClientIdentifierCommandsApi.java |   73 ++
 .../client/feign/helpers/FeignChargesHelper.java   |   25 +
 .../client/feign/helpers/FeignClientHelper.java    |  195 +++
 .../client/feign/helpers/FeignCodeHelper.java      |   14 +
 .../feign/helpers/FeignCollateralHelper.java       |   23 +
 .../FeignFinancialActivityAccountHelper.java       |   28 +
 .../feign/helpers/FeignJournalEntryHelper.java     |   56 +-
 .../client/feign/helpers/FeignNoteHelper.java      |   64 +
 .../feign/helpers/FeignShareAccountHelper.java     |    6 +
 .../feign/modules/ChargeRequestBuilders.java       |   31 +
 .../feign/modules/ClientRequestBuilders.java       |   28 +
 .../client/feign/modules/ClientTestData.java       |   43 +
 .../integrationtests/common/ClientChargesTest.java |  126 +-
 .../integrationtests/common/ClientHelper.java      |  639 ----------
 .../ProvisioningCategoryDeleteIntegrationTest.java |   38 +-
 .../common/ProvisioningIntegrationTest.java        |  113 +-
 .../common/TaxComponentHelper.java                 |   38 -
 .../integrationtests/common/TaxGroupHelper.java    |   43 -
 .../common/accounting/AccountHelper.java           |   15 -
 .../accounting/FinancialActivityAccountHelper.java |   21 -
 .../common/accounting/JournalEntryHelper.java      |   44 -
 .../common/charges/ChargesHelper.java              |  196 ---
 .../fixeddeposit/FixedDepositAccountHelper.java    |    8 -
 .../RecurringDepositAccountHelper.java             |  658 ----------
 .../RecurringDepositAccountStatusChecker.java      |  108 --
 .../RecurringDepositProductHelper.java             |  520 --------
 .../common/savings/SavingsAccountHelper.java       |    9 -
 .../common/savings/SavingsProductHelper.java       |   15 -
 .../integrationtests/common/system/CodeHelper.java |   36 -
 53 files changed, 2181 insertions(+), 4708 deletions(-)