You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/15 13:11:11 UTC
[GitHub] [incubator-inlong] shink opened a new pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
shink opened a new pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511
Fixes: #2509
### Motivation
The audit feature has been brought in #1738. Next we should add support for it on Docker Compose.
### Modifications
- `docker/docker-compose/docker-compose.yml`
- `docker/docker-compose/README.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a change in pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
shink commented on a change in pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511#discussion_r806815161
##########
File path: docker/docker-compose/docker-compose.yml
##########
@@ -33,6 +33,19 @@ services:
- ./mysql:/var/lib/mysql
- ./sql:/docker-entrypoint-initdb.d
+ pulsar:
+ image: apachepulsar/pulsar
+ container_name: pulsar
+ environment:
+ - PULSAR_MEM="-Xms256m -Xmx512m -XX:MaxDirectMemorySize=1g"
+ ports:
+ - "6650:6650"
+ - "8181:8080"
Review comment:
@dockerzhang Is it OK to expose port 8181 on the machine?
##########
File path: docker/docker-compose/docker-compose.yml
##########
@@ -123,4 +136,20 @@ services:
ports:
- "8008:8008"
volumes:
- - ./collect-data:/data/collect-data
\ No newline at end of file
+ - ./collect-data:/data/collect-data
+
+ audit:
+ image: inlong/audit:latest
+ container_name: audit
+ depends_on:
+ mysql:
+ condition: service_healthy
Review comment:
@dockerzhang BTW, version 3 of Docker Compose no longer supports the `condition` form of `depends_on`, should we adapt it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511#discussion_r806853698
##########
File path: docker/docker-compose/docker-compose.yml
##########
@@ -123,4 +136,20 @@ services:
ports:
- "8008:8008"
volumes:
- - ./collect-data:/data/collect-data
\ No newline at end of file
+ - ./collect-data:/data/collect-data
+
+ audit:
+ image: inlong/audit:latest
+ container_name: audit
+ depends_on:
+ mysql:
+ condition: service_healthy
Review comment:
it's better to use another PR to adapt the 3.0 docker-compose after this issue is fixed.
##########
File path: docker/docker-compose/docker-compose.yml
##########
@@ -33,6 +33,19 @@ services:
- ./mysql:/var/lib/mysql
- ./sql:/docker-entrypoint-initdb.d
+ pulsar:
+ image: apachepulsar/pulsar
+ container_name: pulsar
+ environment:
+ - PULSAR_MEM="-Xms256m -Xmx512m -XX:MaxDirectMemorySize=1g"
+ ports:
+ - "6650:6650"
+ - "8181:8080"
Review comment:
the 8080 port for pulsar admin url is not used by audit ,we can remove this port mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
shink commented on pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511#issuecomment-1041015705
@dockerzhang OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a change in pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
shink commented on a change in pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511#discussion_r807459301
##########
File path: docker/docker-compose/README.md
##########
@@ -9,10 +9,11 @@ Requirements:
### Deploy
-Manually copy SQL files from `inlong-manager/sql` to the `docker/compose/sql` directory.
+Manually copy SQL files from `inlong-manager/sql` and `inlong-audit/sql` to the `docker/docker-compose/sql` directory.
```shell
-cp inlong-manager/sql/apache_inlong_manager.sql docker/docker-compose/sql
+cp inlong-manager/sql/apache_inlong_manager.sql docker/docker-compose/sql
+cp inlong-audit/sql/apache_inlong_audit.sql docker/docker-compose/sql
```
Review comment:
@dockerzhang It seems that `apache_inlong_manager.sql` is not in the `inlong-manager/sql` directory. Which path should be changed to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a change in pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
shink commented on a change in pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511#discussion_r807459301
##########
File path: docker/docker-compose/README.md
##########
@@ -9,10 +9,11 @@ Requirements:
### Deploy
-Manually copy SQL files from `inlong-manager/sql` to the `docker/compose/sql` directory.
+Manually copy SQL files from `inlong-manager/sql` and `inlong-audit/sql` to the `docker/docker-compose/sql` directory.
```shell
-cp inlong-manager/sql/apache_inlong_manager.sql docker/docker-compose/sql
+cp inlong-manager/sql/apache_inlong_manager.sql docker/docker-compose/sql
+cp inlong-audit/sql/apache_inlong_audit.sql docker/docker-compose/sql
```
Review comment:
@dockerzhang It seems that the `apache_inlong_manager.sql` is not in the `inlong-manager/sql` directory. Which path should be changed to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a change in pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
shink commented on a change in pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511#discussion_r806824727
##########
File path: docker/docker-compose/docker-compose.yml
##########
@@ -123,4 +136,20 @@ services:
ports:
- "8008:8008"
volumes:
- - ./collect-data:/data/collect-data
\ No newline at end of file
+ - ./collect-data:/data/collect-data
+
+ audit:
+ image: inlong/audit:latest
+ container_name: audit
+ depends_on:
+ mysql:
+ condition: service_healthy
Review comment:
@dockerzhang BTW, version 3 of Docker Compose no longer supports the `condition` form of `depends_on`, should we adapt it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] shink commented on a change in pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
shink commented on a change in pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511#discussion_r806815161
##########
File path: docker/docker-compose/docker-compose.yml
##########
@@ -33,6 +33,19 @@ services:
- ./mysql:/var/lib/mysql
- ./sql:/docker-entrypoint-initdb.d
+ pulsar:
+ image: apachepulsar/pulsar
+ container_name: pulsar
+ environment:
+ - PULSAR_MEM="-Xms256m -Xmx512m -XX:MaxDirectMemorySize=1g"
+ ports:
+ - "6650:6650"
+ - "8181:8080"
Review comment:
@dockerzhang Is it OK to expose port 8181 on the machine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511#discussion_r806853698
##########
File path: docker/docker-compose/docker-compose.yml
##########
@@ -123,4 +136,20 @@ services:
ports:
- "8008:8008"
volumes:
- - ./collect-data:/data/collect-data
\ No newline at end of file
+ - ./collect-data:/data/collect-data
+
+ audit:
+ image: inlong/audit:latest
+ container_name: audit
+ depends_on:
+ mysql:
+ condition: service_healthy
Review comment:
it's better to use another PR to adapt the 3.0 docker-compose after this issue is fixed.
##########
File path: docker/docker-compose/docker-compose.yml
##########
@@ -33,6 +33,19 @@ services:
- ./mysql:/var/lib/mysql
- ./sql:/docker-entrypoint-initdb.d
+ pulsar:
+ image: apachepulsar/pulsar
+ container_name: pulsar
+ environment:
+ - PULSAR_MEM="-Xms256m -Xmx512m -XX:MaxDirectMemorySize=1g"
+ ports:
+ - "6650:6650"
+ - "8181:8080"
Review comment:
the 8080 port for pulsar admin url is not used by audit ,we can remove this port mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511#issuecomment-1041014396
@shink please update the related document on [office website](https://inlong.apache.org/docs/next/deployment/docker), the project repo is at `https://github.com/apache/incubator-inlong-website`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #2511: [INLONG-2509][Feature][Audit][DockerCompose] Add support for Audit on Docker Compose
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #2511:
URL: https://github.com/apache/incubator-inlong/pull/2511#discussion_r807469234
##########
File path: docker/docker-compose/README.md
##########
@@ -9,10 +9,11 @@ Requirements:
### Deploy
-Manually copy SQL files from `inlong-manager/sql` to the `docker/compose/sql` directory.
+Manually copy SQL files from `inlong-manager/sql` and `inlong-audit/sql` to the `docker/docker-compose/sql` directory.
```shell
-cp inlong-manager/sql/apache_inlong_manager.sql docker/docker-compose/sql
+cp inlong-manager/sql/apache_inlong_manager.sql docker/docker-compose/sql
+cp inlong-audit/sql/apache_inlong_audit.sql docker/docker-compose/sql
```
Review comment:
after compiled, `apache_inlong_manager.sql` in `inlong-manager/sql/`,`apache_inlong_audit.sql` in `inlong-audit/sql/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org