[GitHub] spark pull request #20886: [SPARK-19724][SQL]create a managed table with an ...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20886#discussion_r178470143
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala ---
    @@ -103,6 +103,60 @@ class InMemoryCatalogedDDLSuite extends DDLSuite with SharedSQLContext with Befo
         }
       }
     
    +  test("CTAS a managed table with the existing empty directory") {
    +    val tableLoc = new File(spark.sessionState.catalog.defaultTablePath(TableIdentifier("tab1")))
    +    try {
    +      tableLoc.mkdir()
    +      withTable("tab1") {
    +        sql("CREATE TABLE tab1 USING PARQUET AS SELECT 1, 'a'")
    --- End diff --
    
    Move them to `DDLSuite`? Change the format based on `isUsingHiveMetastore`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org