You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/05 19:33:48 UTC

[GitHub] [incubator-nuttx] davids5 opened a new pull request #1202: stm32h7:Kconfig limit STM32H7_SPIn_COMMTYPE range to valid values

davids5 opened a new pull request #1202:
URL: https://github.com/apache/incubator-nuttx/pull/1202


   ## Summary
   
   For the stm32h7  Kconfig  limit STM32H7_SPIn_COMMTYPE range to valid values.
   
   ## Impact
   Joyful!
   
   This may save you a few days of debugging and keep you sane, when oldconfig sets it to a bad value. Mine had 100. Fun!
   
   ## Testing
   
   ran 'make menuconfig`, 
   
   hand edited the file set it to 8 - ir was forced to the default. Yeah!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #1202: stm32h7:Kconfig limit STM32H7_SPIn_COMMTYPE range to valid values

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1202:
URL: https://github.com/apache/incubator-nuttx/pull/1202#issuecomment-639771838


   Thank you @Ouss4!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #1202: stm32h7:Kconfig limit STM32H7_SPIn_COMMTYPE range to valid values

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1202:
URL: https://github.com/apache/incubator-nuttx/pull/1202#issuecomment-639747203


   @fyi @jlaitine 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1202: stm32h7:Kconfig limit STM32H7_SPIn_COMMTYPE range to valid values

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1202:
URL: https://github.com/apache/incubator-nuttx/pull/1202


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jlaitine commented on pull request #1202: stm32h7:Kconfig limit STM32H7_SPIn_COMMTYPE range to valid values

Posted by GitBox <gi...@apache.org>.
jlaitine commented on pull request #1202:
URL: https://github.com/apache/incubator-nuttx/pull/1202#issuecomment-640387119


   Thank you! And sorry for that... I never realized that oldconfig did that. Somehow  one would expect that it gets set to "default" if not set before!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org