You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/28 13:24:29 UTC
[GitHub] [flink] twalthr opened a new pull request #11253: Flink 16336
twalthr opened a new pull request #11253: Flink 16336
URL: https://github.com/apache/flink/pull/11253
## What is the purpose of the change
Uses the new type system with new type inference in temporal table functions.
Depends on FLINK-16261.
## Brief change log
Function now implements both `getResultType()` and `getTypeInference()`.
## Verifying this change
This change is already covered by existing tests, such as `TemporalJoinITCase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on a change in pull request #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#discussion_r392171630
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalTableFunctionScan.scala
##########
@@ -96,11 +96,12 @@ class FlinkLogicalTableFunctionScanConverter
return false
}
val rexCall = logicalTableFunction.getCall.asInstanceOf[RexCall]
- if (!rexCall.getOperator.isInstanceOf[TableSqlFunction]) {
- return false
+ val functionDefinition = rexCall.getOperator match {
+ case tsf: TableSqlFunction => tsf.udtf
+ case bsf: BridgingSqlFunction => bsf.getDefinition
Review comment:
In the catalog layer, see `FunctionCatalogOperatorTable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151026916",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153170857",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1368ad6d7262321e92a1e8c70211bc16a61dd05 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153170857) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151026916",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153170857",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1368ad6d7262321e92a1e8c70211bc16a61dd05 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153170857) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11253: [FLINK-16336][table]
Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9db7f819a428727e0cef951a237c95c34a19477 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11253: [FLINK-16336][table]
Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592512240
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c9db7f819a428727e0cef951a237c95c34a19477 (Fri Feb 28 13:27:59 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#discussion_r392170744
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalTableFunctionScan.scala
##########
@@ -96,11 +96,12 @@ class FlinkLogicalTableFunctionScanConverter
return false
}
val rexCall = logicalTableFunction.getCall.asInstanceOf[RexCall]
- if (!rexCall.getOperator.isInstanceOf[TableSqlFunction]) {
- return false
+ val functionDefinition = rexCall.getOperator match {
+ case tsf: TableSqlFunction => tsf.udtf
+ case bsf: BridgingSqlFunction => bsf.getDefinition
Review comment:
This is just for my understanding, but where is the bridging function created?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151026916",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9db7f819a428727e0cef951a237c95c34a19477 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151026916) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740)
* d1368ad6d7262321e92a1e8c70211bc16a61dd05 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151026916",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9db7f819a428727e0cef951a237c95c34a19477 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151026916) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151026916",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153170857",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
}, {
"hash" : "4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1368ad6d7262321e92a1e8c70211bc16a61dd05 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153170857) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284)
* 4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #11253: [FLINK-16336][table]
Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-598750105
Lools good to merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on a change in pull request #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#discussion_r392172366
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala
##########
@@ -562,6 +562,13 @@ abstract class TableTestUtil(
testingTableEnv.scan(name)
}
+ /**
+ * Registers a [[UserDefinedFunction]] according to FLIP-65.
+ */
+ def addTemporarySystemFunction(name: String, function: UserDefinedFunction): Unit = {
Review comment:
Good point, I will add usage. It is definitely necessary to have in the utils otherwise we have no means to test new functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr closed pull request #11253: [FLINK-16336][table]
Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151026916",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9db7f819a428727e0cef951a237c95c34a19477 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151026916) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151026916",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153170857",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9db7f819a428727e0cef951a237c95c34a19477 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151026916) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740)
* d1368ad6d7262321e92a1e8c70211bc16a61dd05 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153170857) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151026916",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153170857",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
}, {
"hash" : "4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153201488",
"triggerID" : "4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c",
"triggerType" : "PUSH"
}, {
"hash" : "4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153201488",
"triggerID" : "598753216",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153201488)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151026916",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
}, {
"hash" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153170857",
"triggerID" : "d1368ad6d7262321e92a1e8c70211bc16a61dd05",
"triggerType" : "PUSH"
}, {
"hash" : "4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153201488",
"triggerID" : "4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c",
"triggerType" : "PUSH"
}, {
"hash" : "4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153201488",
"triggerID" : "598753216",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d1368ad6d7262321e92a1e8c70211bc16a61dd05 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153170857) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6284)
* 4e1c4f61f4e477262eb3d1d4fa67c97bcec1b85c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153201488)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on issue #11253: [FLINK-16336][table] Add
new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
twalthr commented on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-598753216
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#discussion_r392170345
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala
##########
@@ -562,6 +562,13 @@ abstract class TableTestUtil(
testingTableEnv.scan(name)
}
+ /**
+ * Registers a [[UserDefinedFunction]] according to FLIP-65.
+ */
+ def addTemporarySystemFunction(name: String, function: UserDefinedFunction): Unit = {
Review comment:
Why is this added? It's not used anywhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11253:
[FLINK-16336][table] Add new type inference for temporal table functions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11253: [FLINK-16336][table] Add new type inference for temporal table functions
URL: https://github.com/apache/flink/pull/11253#issuecomment-592517598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151026916",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
}, {
"hash" : "c9db7f819a428727e0cef951a237c95c34a19477",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740",
"triggerID" : "c9db7f819a428727e0cef951a237c95c34a19477",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9db7f819a428727e0cef951a237c95c34a19477 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151026916) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5740)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services