You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "bigDouble46 (via GitHub)" <gi...@apache.org> on 2023/12/02 06:03:38 UTC
[PR] [#4065] fix loaded variable not assigned [servicecomb-java-chassis]
bigDouble46 opened a new pull request, #4076:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4076
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4065] fix loaded variable not assigned [servicecomb-java-chassis]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj merged PR #4076:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4065] fix loaded variable not assigned [servicecomb-java-chassis]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4076:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4076#issuecomment-1837058131
## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4076?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`76854ff`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/76854ffd1ddb992a51ce743bf9ab201935ce38f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 74.14% compared to head [(`91a49eb`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4076?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 74.13%.
> :exclamation: Current head 91a49eb differs from pull request most recent head 29500ff. Consider uploading reports for the commit 29500ff to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.8.x #4076 +/- ##
============================================
- Coverage 74.14% 74.13% -0.01%
Complexity 707 707
============================================
Files 1598 1598
Lines 40252 40255 +3
Branches 3675 3676 +1
============================================
- Hits 29844 29843 -1
- Misses 8917 8919 +2
- Partials 1491 1493 +2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4076?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org