[GitHub] [beam] mattcasters commented on pull request #15916: [BEAM-1857] Add Neo4jIO (initial code drop)

[GitBox <gi...@apache.org>]

mattcasters commented on pull request #15916:
URL: https://github.com/apache/beam/pull/15916#issuecomment-970262918


   On the subject of BEAM-10402 and the checker framework I think that in the end it's a bit of a Java "obfuscation" puzzle.  I noticed that a lot of other PRs for the case simply result in adding `@SuppressWarnings({"nullness"})` to be done with this. 
   I'm just visiting the project but I would advice some documentation around the "Run Java PreCommit" check and on how to run this locally so you can actually test for the things going wrong before doing a commit to the codebase.  The recommended advice listed in BEAM-10402 is no longer valid it seems as `./gradlew :sdks:java:io:neo4j:compileJava -PenableChecker=true` runs just fine locally but fails here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org