You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/29 06:03:38 UTC

[GitHub] [spark] srielau commented on pull request #38728: [SPARK-41204] [CONNECT] Migrate custom exceptions to use Spark exceptions

srielau commented on PR #38728:
URL: https://github.com/apache/spark/pull/38728#issuecomment-1330129095

   General comment. You use CONNECT as error class, everything else is a sub error class. Many of these are INVALID_PLAN.
   How many errors total do you expect?
   Note that at present we support only two levels.
   Would it make sense to use CONNECT (or an abbreviation of it) as a prefix and then perhaps subclass at INVALID_PLAN:
   CONNECT_INVALID_PLAN.xxx
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org