[PATCH] Re: Why is JMX support in builds optional?

["David W." <da...@optonline.net>]

The attached patch requires MX4J in builds.  It also eliminates the need for
the other patch I posted (which seemed to get less attention than this
topic...).  Again, I hope this is the right format for patches -- please
complain at me if it isn't.

Unresolved issues:
-- The kernal.xml still uses NoopSystemManager as a default SystemManager
-- Maybe place a jndi.properties file for MX4J in the classpath
-- I'll try to think of more.

David Weitzman

----- Original Message -----
From: "Peter Donald" <pe...@apache.org>
To: "Avalon-Phoenix Developers List" <av...@jakarta.apache.org>
Sent: Thursday, September 05, 2002 6:54 PM
Subject: Re: Why is JMX support in builds optional?


> On Fri, 6 Sep 2002 07:55, David W. wrote:
> > I'm just curious, why JMX optional for builds?  It only adds about 500k
to
> > an already 3meg distribution, and parts of building, configuring, and
> > (un)launching (and as a byproduct, documenting) would be simpler if
support
> > for JMX could just be assumed.
>
> Historical reasons really. We could/should require jmx to build and use it
by
> default. Someone just needs to actually do it ;)
>
> --
> Cheers,
>
> Peter Donald
> ------------------------------------
> The two secrets to success:
>    1- Don't tell anyone everything.
> ------------------------------------
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>

Re: [PATCH] Re: Why is JMX support in builds optional?

[Peter Donald <pe...@apache.org>]

On Fri, 6 Sep 2002 09:35, David W. wrote:
> The attached patch requires MX4J in builds.  It also eliminates the need
> for the other patch I posted (which seemed to get less attention than this
> topic...).  Again, I hope this is the right format for patches -- please
> complain at me if it isn't.

applied - thanks!

Usually we prefer patches in "unified" format which you can generate via 
passing "-u" option to cvs like

cvs diff -u Main.java

Usually we also prefer that the diffs be take from the root directory. ie we 
would prefer


$ cvs diff -u src/java/org/...../MyFile.java

over

$ cd jakarta-avalon-phoenix/src/java/org/...../
$ cvs diff -u MyFile.java

More details on submitting patches are available at bottom of

http://jakarta.apache.org/site/source.html

> Unresolved issues:
> -- The kernal.xml still uses NoopSystemManager as a default SystemManager

Okay - will do that now.

> -- Maybe place a jndi.properties file for MX4J in the classpath

that would be good.

-- 
Cheers,

Peter Donald
*-----------------------------------------------------*
| Never argue with an idiot, they'll drag you down to |
| their level, and beat you with experience           |
*-----------------------------------------------------* 


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>