You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/07/22 19:19:58 UTC
[Impala-ASF-CR] IMPALA-11451: Add net-tools dependency to bootstrap system.sh
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18774
Change subject: IMPALA-11451: Add net-tools dependency to bootstrap_system.sh
......................................................................
IMPALA-11451: Add net-tools dependency to bootstrap_system.sh
TestKrpcSocket uses netstat as part of its test. netstat
is provided by the net-tools package on Ubuntu and Centos.
This adds that as a dependency in bootstrap_system.sh.
Docker-based tests had been hitting this test failure,
because they start from a clean docker image.
Testing:
- Ran docker-based tests and TestKrpcSocket now passes
Change-Id: I9ad704e408d4ca4741178d4ea7a857bf30d4cfb6
---
M bin/bootstrap_system.sh
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/18774/1
--
To view, visit http://gerrit.cloudera.org:8080/18774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ad704e408d4ca4741178d4ea7a857bf30d4cfb6
Gerrit-Change-Number: 18774
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11451: Add net-tools dependency to bootstrap system.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18774 )
Change subject: IMPALA-11451: Add net-tools dependency to bootstrap_system.sh
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11027/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad704e408d4ca4741178d4ea7a857bf30d4cfb6
Gerrit-Change-Number: 18774
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 19:41:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11451: Add net-tools dependency to bootstrap system.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18774 )
Change subject: IMPALA-11451: Add net-tools dependency to bootstrap_system.sh
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad704e408d4ca4741178d4ea7a857bf30d4cfb6
Gerrit-Change-Number: 18774
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jul 2022 22:30:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11451: Add net-tools dependency to bootstrap system.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18774 )
Change subject: IMPALA-11451: Add net-tools dependency to bootstrap_system.sh
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad704e408d4ca4741178d4ea7a857bf30d4cfb6
Gerrit-Change-Number: 18774
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jul 2022 17:36:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11451: Add net-tools dependency to bootstrap system.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18774 )
Change subject: IMPALA-11451: Add net-tools dependency to bootstrap_system.sh
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8362/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad704e408d4ca4741178d4ea7a857bf30d4cfb6
Gerrit-Change-Number: 18774
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jul 2022 17:36:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11451: Add net-tools dependency to bootstrap system.sh
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18774 )
Change subject: IMPALA-11451: Add net-tools dependency to bootstrap_system.sh
......................................................................
Patch Set 1: Code-Review+1
I also ran into this, seems like a straight-forward fix.
--
To view, visit http://gerrit.cloudera.org:8080/18774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad704e408d4ca4741178d4ea7a857bf30d4cfb6
Gerrit-Change-Number: 18774
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 19:48:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11451: Add net-tools dependency to bootstrap system.sh
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18774 )
Change subject: IMPALA-11451: Add net-tools dependency to bootstrap_system.sh
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad704e408d4ca4741178d4ea7a857bf30d4cfb6
Gerrit-Change-Number: 18774
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 20:56:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11451: Add net-tools dependency to bootstrap system.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18774 )
Change subject: IMPALA-11451: Add net-tools dependency to bootstrap_system.sh
......................................................................
IMPALA-11451: Add net-tools dependency to bootstrap_system.sh
TestKrpcSocket uses netstat as part of its test. netstat
is provided by the net-tools package on Ubuntu and Centos.
This adds that as a dependency in bootstrap_system.sh.
Docker-based tests had been hitting this test failure,
because they start from a clean docker image.
Testing:
- Ran docker-based tests and TestKrpcSocket now passes
Change-Id: I9ad704e408d4ca4741178d4ea7a857bf30d4cfb6
Reviewed-on: http://gerrit.cloudera.org:8080/18774
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_system.sh
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ad704e408d4ca4741178d4ea7a857bf30d4cfb6
Gerrit-Change-Number: 18774
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>