You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/24 13:38:13 UTC

[GitHub] [apisix-website] stu01509 opened a new pull request #270: Feat #266 speed up static file

stu01509 opened a new pull request #270:
URL: https://github.com/apache/apisix-website/pull/270


   Fixes: #266
   
   Changes:
   speed up static file
   <!-- Add here what changes were made in this pull request and if possible provide links showcasing the changes. -->
   
   Screenshots of the change:
   
   <!-- Add screenshots depicting the changes. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] stu01509 commented on pull request #270: Feat #266 speed up static file

Posted by GitBox <gi...@apache.org>.
stu01509 commented on pull request #270:
URL: https://github.com/apache/apisix-website/pull/270#issuecomment-806361951


   Hi @juzhiyuan 
   
   Update the commit :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] stu01509 commented on a change in pull request #270: Feat #266 speed up static file

Posted by GitBox <gi...@apache.org>.
stu01509 commented on a change in pull request #270:
URL: https://github.com/apache/apisix-website/pull/270#discussion_r600988537



##########
File path: website/src/pages/index.js
##########
@@ -120,7 +120,7 @@ const Showcase = () => {
   }
   const showcases = siteConfig.customFields.showcases.map((user) => (
     <a href={user.infoLink} key={user.infoLink} target="_blank">
-      <img className="user-logo" src={user.image} alt={user.caption} />
+      <img className="user-logo" src={'https://cdn.jsdelivr.net/gh/apache/apisix-website@master/website/static/' +  user.image} alt={user.caption} />

Review comment:
       yup. missing the `/img` path, I will fix it later 😀




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #270: Feat #266 speed up static file

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #270:
URL: https://github.com/apache/apisix-website/pull/270#discussion_r600979393



##########
File path: website/src/pages/index.js
##########
@@ -120,7 +120,7 @@ const Showcase = () => {
   }
   const showcases = siteConfig.customFields.showcases.map((user) => (
     <a href={user.infoLink} key={user.infoLink} target="_blank">
-      <img className="user-logo" src={user.image} alt={user.caption} />
+      <img className="user-logo" src={'https://cdn.jsdelivr.net/gh/apache/apisix-website@master/website/static/' +  user.image} alt={user.caption} />

Review comment:
       ![image](https://user-images.githubusercontent.com/2106987/112404902-2d2eba00-8d4c-11eb-8f05-6674f7af9e95.png)
   
   https://deploy-preview-270--apisix.netlify.app/
   
   Broken, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] LiteSun merged pull request #270: Feat #266 speed up static file

Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #270:
URL: https://github.com/apache/apisix-website/pull/270


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org