You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/07/17 18:05:39 UTC
svn commit: r1891624 -
/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java
Author: tilman
Date: Sat Jul 17 18:05:39 2021
New Revision: 1891624
URL: http://svn.apache.org/viewvc?rev=1891624&view=rev
Log:
PDFBOX-4892: optimize + fix javadoc, as suggested by valerybokov
Modified:
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java?rev=1891624&r1=1891623&r2=1891624&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cmap/CMap.java Sat Jul 17 18:05:39 2021
@@ -179,12 +179,12 @@ public class CMap
}
if (LOG.isWarnEnabled())
{
- String seq = "";
+ StringBuilder sb = new StringBuilder();
for (int i = 0; i < maxCodeLength; ++i)
{
- seq += String.format("0x%02X (%04o) ", bytes[i], bytes[i]);
+ sb.append(String.format("0x%02X (%04o) ", bytes[i], bytes[i]));
}
- LOG.warn("Invalid character code sequence " + seq + "in CMap " + cmapName);
+ LOG.warn("Invalid character code sequence " + sb + "in CMap " + cmapName);
}
// PDFBOX-4811 reposition to where we were after initial read
if (in.markSupported())
@@ -384,7 +384,7 @@ public class CMap
/**
* Get the code bytes for an unicode string.
*
- * @param unicode
+ * @param unicode The unicode string.
* @return the code bytes or null if there is none.
*/
public byte[] getCodesFromUnicode(String unicode)