You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/08 15:10:51 UTC

[GitHub] [spark] cloud-fan commented on pull request #32030: [SPARK-34989] Improve the performance of mapChildren and withNewChildren methods

cloud-fan commented on pull request #32030:
URL: https://github.com/apache/spark/pull/32030#issuecomment-815903141


   This reminds me of `TimeZoneAwareExpression.withTimeZone` and `ImperativeAggregate.withNewMutableAggBufferOffset`. They can be simply implemented with case class copy, but unfortunately, Scala is not flexible enough to allow you to implement it in a generic way :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org