You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/05 10:00:16 UTC
[GitHub] [flink-shaded] zentol opened a new pull request #100: [FLINK-24447][zk] Bundle netty
zentol opened a new pull request #100:
URL: https://github.com/apache/flink-shaded/pull/100
With this PR we bundle Netty for ZK 3.5, because it is required for SSL setups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-shaded] zentol commented on a change in pull request #100: [FLINK-24447][zk] Bundle netty
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #100:
URL: https://github.com/apache/flink-shaded/pull/100#discussion_r724110204
##########
File path: flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35/src/main/resources/META-INF/NOTICE
##########
@@ -7,6 +7,14 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.google.guava:guava:27.0.1-jre
Review comment:
There are separate modules for the ZK versions. zookeeper-35 for 3.5, zookeeper34 for 3.4.
##########
File path: flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35/src/main/resources/META-INF/NOTICE
##########
@@ -7,6 +7,14 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.google.guava:guava:27.0.1-jre
Review comment:
There are separate modules for the ZK versions. zookeeper-35 for 3.5, zookeeper-34 for 3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-shaded] zentol commented on a change in pull request #100: [FLINK-24447][zk] Bundle netty
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #100:
URL: https://github.com/apache/flink-shaded/pull/100#discussion_r724110204
##########
File path: flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35/src/main/resources/META-INF/NOTICE
##########
@@ -7,6 +7,14 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.google.guava:guava:27.0.1-jre
Review comment:
There are separate modules for the ZK versions. zookeeper-35 for 3.5, zookeeper-34 for 3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-shaded] zentol merged pull request #100: [FLINK-24447][zk] Bundle netty
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #100:
URL: https://github.com/apache/flink-shaded/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-shaded] XComp commented on a change in pull request #100: [FLINK-24447][zk] Bundle netty
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #100:
URL: https://github.com/apache/flink-shaded/pull/100#discussion_r724055043
##########
File path: flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35/src/main/resources/META-INF/NOTICE
##########
@@ -7,6 +7,14 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.google.guava:guava:27.0.1-jre
Review comment:
It's not really connected to this change. But I realize that the shaded plugin adds `org.apache.zookeeper.zookeeper` `3.5.9` and `3.4.14` which is because we want to support ZK 3.5 and 3.4, I guess? But the NOTICE file only mentions `3.5.9`. Is that correct or should we also add `3.4.14`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-shaded] XComp commented on a change in pull request #100: [FLINK-24447][zk] Bundle netty
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #100:
URL: https://github.com/apache/flink-shaded/pull/100#discussion_r724055043
##########
File path: flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35/src/main/resources/META-INF/NOTICE
##########
@@ -7,6 +7,14 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.google.guava:guava:27.0.1-jre
Review comment:
It's not really connected to this change. But I realize that the shaded plugin adds `org.apache.zookeeper.zookeeper` `3.5.9` and `3.4.14` which is because we want to support ZK 3.5 and 3.4, I guess? But the NOTICE file only mentions `3.5.9`. Is that correct or should we also add `3.4.14`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-shaded] zentol merged pull request #100: [FLINK-24447][zk] Bundle netty
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #100:
URL: https://github.com/apache/flink-shaded/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-shaded] zentol commented on a change in pull request #100: [FLINK-24447][zk] Bundle netty
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #100:
URL: https://github.com/apache/flink-shaded/pull/100#discussion_r724110204
##########
File path: flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35/src/main/resources/META-INF/NOTICE
##########
@@ -7,6 +7,14 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.google.guava:guava:27.0.1-jre
Review comment:
There are separate modules for the ZK versions. zookeeper-35 for 3.5, zookeeper34 for 3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org