You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/12 12:26:18 UTC

[GitHub] [arrow] lidavidm commented on pull request #13108: ARROW-15415: [C++] Fixes for MSVC + vcpkg Debug build

lidavidm commented on PR #13108:
URL: https://github.com/apache/arrow/pull/13108#issuecomment-1124929674

   > For the tracing impl incomplete type issue, it seemed like the fix was to make sure that any file with the line:
   > 
   > ```c++
   > #include "arrow/compute/exec/exec_plan.h" // contains #include "arrow/util/tracing.h"
   > ```
   > 
   > Also has the line
   > 
   > ```c++
   > #include "arrow/util/tracing_internal.h"
   > ```
   
   Hmm, isn't that a problem? `exec_plan.h` is a public API, so this means the header is not usable by applications?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org