You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/01/27 12:53:50 UTC
Review Request 56016: Expanded a comment about TaskStatus protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56016/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/mesos.proto 37a97f6bb3c229c0ae16a263e4de458010fba32b
include/mesos/v1/mesos.proto 31563b79010fff4c07b1c0ab691c0c7635035845
Diff: https://reviews.apache.org/r/56016/diff/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 56016: Added a note about task status updates in
scheduler and internal API.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56016/#review168972
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 14, 2017, 2:05 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56016/
> -----------------------------------------------------------
>
> (Updated March 14, 2017, 2:05 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto d04924a49d0bf28952af6cb72d972cac61e6f781
> include/mesos/v1/scheduler/scheduler.proto 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce
> src/messages/messages.proto 508ff5960eb70b1299ef5ec02c23852c0088d295
>
>
> Diff: https://reviews.apache.org/r/56016/diff/4/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 56016: Added a note about task status updates in
scheduler and internal API.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56016/#review168997
-----------------------------------------------------------
Ship it!
Ship It!
- Gast�n Kleiman
On March 15, 2017, 12:44 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56016/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 12:44 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto d04924a49d0bf28952af6cb72d972cac61e6f781
> include/mesos/v1/scheduler/scheduler.proto 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce
> src/messages/messages.proto 508ff5960eb70b1299ef5ec02c23852c0088d295
>
>
> Diff: https://reviews.apache.org/r/56016/diff/5/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 56016: Added a note about task status updates in
scheduler and internal API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56016/
-----------------------------------------------------------
(Updated March 15, 2017, 12:44 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto d04924a49d0bf28952af6cb72d972cac61e6f781
include/mesos/v1/scheduler/scheduler.proto 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce
src/messages/messages.proto 508ff5960eb70b1299ef5ec02c23852c0088d295
Diff: https://reviews.apache.org/r/56016/diff/5/
Changes: https://reviews.apache.org/r/56016/diff/4-5/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 56016: Added a note about task status updates in
scheduler and internal API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56016/
-----------------------------------------------------------
(Updated March 14, 2017, 2:05 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto d04924a49d0bf28952af6cb72d972cac61e6f781
include/mesos/v1/scheduler/scheduler.proto 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce
src/messages/messages.proto 508ff5960eb70b1299ef5ec02c23852c0088d295
Diff: https://reviews.apache.org/r/56016/diff/4/
Changes: https://reviews.apache.org/r/56016/diff/3-4/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 56016: Added a note about task status updates in
scheduler and internal API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56016/
-----------------------------------------------------------
(Updated March 7, 2017, 8:38 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto d04924a49d0bf28952af6cb72d972cac61e6f781
include/mesos/v1/scheduler/scheduler.proto 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce
src/messages/messages.proto 508ff5960eb70b1299ef5ec02c23852c0088d295
Diff: https://reviews.apache.org/r/56016/diff/3/
Changes: https://reviews.apache.org/r/56016/diff/2-3/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 56016: Added a note about task status updates in
scheduler and internal API.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56016/#review167555
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 28, 2017, 3:46 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56016/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 3:46 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto d04924a49d0bf28952af6cb72d972cac61e6f781
> include/mesos/v1/scheduler/scheduler.proto 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce
> src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698
>
>
> Diff: https://reviews.apache.org/r/56016/diff/2/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 56016: Added a note about task status updates in
scheduler and internal API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56016/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 3:46 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Summary (updated)
-----------------
Added a note about task status updates in scheduler and internal API.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto d04924a49d0bf28952af6cb72d972cac61e6f781
include/mesos/v1/scheduler/scheduler.proto 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce
src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698
Diff: https://reviews.apache.org/r/56016/diff/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 56016: Expanded a comment about TaskStatus
protobuf.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56016/#review163379
-----------------------------------------------------------
include/mesos/mesos.proto (lines 1768 - 1771)
<https://reviews.apache.org/r/56016/#comment234802>
I think this comment belongs in `Update` proto in scheduler.proto and `StatusUpdate` proto, not here.
- Vinod Kone
On Jan. 27, 2017, 12:53 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56016/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 12:53 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 37a97f6bb3c229c0ae16a263e4de458010fba32b
> include/mesos/v1/mesos.proto 31563b79010fff4c07b1c0ab691c0c7635035845
>
> Diff: https://reviews.apache.org/r/56016/diff/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>