[GitHub] [rocketmq] duhenglucky commented on a change in pull request #1702: [ISSUE #1701] Delete invalid method to get next pullBatchSize

[GitBox <gi...@apache.org>]

duhenglucky commented on a change in pull request #1702: [ISSUE #1701] Delete invalid method to get next pullBatchSize
URL: https://github.com/apache/rocketmq/pull/1702#discussion_r363249548
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
 ##########
 @@ -775,7 +771,8 @@ public void run() {
                         subscriptionData = FilterAPI.buildSubscriptionData(defaultLitePullConsumer.getConsumerGroup(),
                             topic, SubscriptionData.SUB_ALL);
                     }
-                    PullResult pullResult = pull(messageQueue, subscriptionData, offset, nextPullBatchSize());
+                    
+                    PullResult pullResult = pull(messageQueue, subscriptionData, offset, defaultLitePullConsumer.getPullBatchSize());
 
 Review comment:
   Although the linkedblockingqueue has default size with Integer.MAX_VALUE, but really useless.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services