You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ahmedabu98 (via GitHub)" <gi...@apache.org> on 2023/10/09 21:53:55 UTC
[PR] Update Dataflow containers [beam]
ahmedabu98 opened a new pull request, #28904:
URL: https://github.com/apache/beam/pull/28904
Updating to include the dependency updates in #28880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Dataflow containers [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28904:
URL: https://github.com/apache/beam/pull/28904#issuecomment-1754105109
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Dataflow containers [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #28904:
URL: https://github.com/apache/beam/pull/28904#discussion_r1353044522
##########
website/www/site/content/en/documentation/runtime/environments.md:
##########
@@ -115,14 +115,13 @@ This method requires building image artifacts from Beam source. For additional i
./gradlew :sdks:java:container:java11:docker
./gradlew :sdks:java:container:java17:docker
./gradlew :sdks:go:container:docker
- ./gradlew :sdks:python:container:py36:docker
./gradlew :sdks:python:container:py38:docker
./gradlew :sdks:python:container:py39:docker
./gradlew :sdks:python:container:py310:docker
./gradlew :sdks:python:container:py311:docker
# Shortcut for building all Python SDKs
- ./gradlew :sdks:python:container buildAll
+ ./gradlew :sdks:python:container:buildAll
Review Comment:
yes, `./gradlew :sdks:python:container buildAll` is not a real command. I suspect the space was by mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Dataflow containers [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28904:
URL: https://github.com/apache/beam/pull/28904#issuecomment-1753963698
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28904?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#28904](https://app.codecov.io/gh/apache/beam/pull/28904?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9280257) into [master](https://app.codecov.io/gh/apache/beam/commit/21f822f6580f04c3bd581005d93846e555982367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (21f822f) will **decrease** coverage by `0.01%`.
> Report is 3 commits behind head on master.
> The diff coverage is `62.50%`.
```diff
@@ Coverage Diff @@
## master #28904 +/- ##
==========================================
- Coverage 72.16% 72.16% -0.01%
==========================================
Files 686 686
Lines 101551 101562 +11
==========================================
+ Hits 73283 73289 +6
- Misses 26690 26695 +5
Partials 1578 1578
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/28904/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/28904/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.61% <62.50%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/beam/pull/28904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://app.codecov.io/gh/apache/beam/pull/28904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <100.00%> (ø)` | |
| [sdks/python/apache\_beam/pipeline.py](https://app.codecov.io/gh/apache/beam/pull/28904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `91.75% <85.71%> (-0.10%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://app.codecov.io/gh/apache/beam/pull/28904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `94.01% <50.00%> (-0.22%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/display.py](https://app.codecov.io/gh/apache/beam/pull/28904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9kaXNwbGF5LnB5) | `92.20% <75.00%> (-1.17%)` | :arrow_down: |
| [sdks/python/apache\_beam/yaml/main.py](https://app.codecov.io/gh/apache/beam/pull/28904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0veWFtbC9tYWluLnB5) | `0.00% <0.00%> (ø)` | |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/28904/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Dataflow containers [beam]
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on code in PR #28904:
URL: https://github.com/apache/beam/pull/28904#discussion_r1352910109
##########
website/www/site/content/en/documentation/runtime/environments.md:
##########
@@ -115,14 +115,13 @@ This method requires building image artifacts from Beam source. For additional i
./gradlew :sdks:java:container:java11:docker
./gradlew :sdks:java:container:java17:docker
./gradlew :sdks:go:container:docker
- ./gradlew :sdks:python:container:py36:docker
./gradlew :sdks:python:container:py38:docker
./gradlew :sdks:python:container:py39:docker
./gradlew :sdks:python:container:py310:docker
./gradlew :sdks:python:container:py311:docker
# Shortcut for building all Python SDKs
- ./gradlew :sdks:python:container buildAll
+ ./gradlew :sdks:python:container:buildAll
Review Comment:
is this change intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Dataflow containers [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 merged PR #28904:
URL: https://github.com/apache/beam/pull/28904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org