You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "machi1990 (via GitHub)" <gi...@apache.org> on 2023/04/22 12:04:33 UTC

[GitHub] [kafka] machi1990 opened a new pull request, #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

machi1990 opened a new pull request, #13626:
URL: https://github.com/apache/kafka/pull/13626

   The sslEngine.setUseClientMode(false) was duplicated when ssl mode is server during SSLEngine creation in DefaultSslEngineFactory.java. The patch attemps to remove the duplicated call.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] machi1990 commented on pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on PR #13626:
URL: https://github.com/apache/kafka/pull/13626#issuecomment-1521299054

   Thanks @maulin-vasavada


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] machi1990 commented on pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on PR #13626:
URL: https://github.com/apache/kafka/pull/13626#issuecomment-1518629843

   Hi @rajinisivaram @maulin-vasavada can you've a look when you've some time? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] omkreddy merged pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

Posted by "omkreddy (via GitHub)" <gi...@apache.org>.
omkreddy merged PR #13626:
URL: https://github.com/apache/kafka/pull/13626


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] machi1990 commented on pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on PR #13626:
URL: https://github.com/apache/kafka/pull/13626#issuecomment-1521462905

   Thanks for the review @divijvaidya 
   
   > As a note to help the reviewers, the removed line in this PR is duplicated by line 192. 
   > https://github.com/apache/kafka/pull/13626/files#diff-4c17123cb45661b014444be8e79c78b3c54ee34dd9668a5bc1b744d985408346R192
   
   That's exactly it. I'll add it to the PRs description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] maulin-vasavada commented on pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

Posted by "maulin-vasavada (via GitHub)" <gi...@apache.org>.
maulin-vasavada commented on PR #13626:
URL: https://github.com/apache/kafka/pull/13626#issuecomment-1520995629

   @machi1990 looks good to me. However you will need a committer to review and merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] machi1990 commented on pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on PR #13626:
URL: https://github.com/apache/kafka/pull/13626#issuecomment-1521519704

   Thanks @omkreddy for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org