You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/03 18:04:10 UTC

[GitHub] [airflow] nuclearpinguin opened a new pull request #7615: [AIRFLOW-6980] Improve system tests and building providers package

nuclearpinguin opened a new pull request #7615: [AIRFLOW-6980] Improve system tests and building providers package
URL: https://github.com/apache/airflow/pull/7615
 
 
   This PR removes initdb from system tests setup as it seems unneccessary operation.
   Also some automatic code changes has been added before building providers package.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package

Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package
URL: https://github.com/apache/airflow/pull/7615#issuecomment-597001164
 
 
   Ok, I got it. Bowler is refactoring everything each time the package is built (we have a for loop on CI).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package
URL: https://github.com/apache/airflow/pull/7615#issuecomment-594223286
 
 
   You need to install bowler in ci_before_install.sh

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin merged pull request #7615: [AIRFLOW-6980] Improve system tests and building providers package

Posted by GitBox <gi...@apache.org>.
nuclearpinguin merged pull request #7615: [AIRFLOW-6980] Improve system tests and building providers package
URL: https://github.com/apache/airflow/pull/7615
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package
URL: https://github.com/apache/airflow/pull/7615#issuecomment-596540482
 
 
   Some static checks :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package
URL: https://github.com/apache/airflow/pull/7615#issuecomment-596805432
 
 
   Can't parse ./airflow/providers/apache/pinot/hooks/pinot.py: ParseError: bad input: type=1, value='exec', context=(' ', (69, 38))
   and failed after 50 minutes :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package

Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package
URL: https://github.com/apache/airflow/pull/7615#issuecomment-596963688
 
 
   > Can't parse ./airflow/providers/apache/pinot/hooks/pinot.py: ParseError: bad input: type=1, value='exec', context=(' ', (69, 38))
   
   That's not a problem (at least not ours, I think it's a bowler not being able to parse file with variable `exec` that overrides the built-in).
   
   The 50 minutes is troubling. I added a fixup with `IN_PROCESS=True` to check if this helps. Locally I have no problem with this build. It's a little bit longer with `IN_PROCESS=True`
   but still under 2 minutes.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package
URL: https://github.com/apache/airflow/pull/7615#issuecomment-597050665
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=h1) Report
   > Merging [#7615](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3f68eea41c78552943fa48851db9d29f925eed7a?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7615/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #7615   +/-   ##
   =======================================
     Coverage   86.95%   86.95%           
   =======================================
     Files         900      900           
     Lines       43605    43605           
   =======================================
     Hits        37915    37915           
     Misses       5690     5690
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...providers/google/cloud/example\_dags/example\_dlp.py](https://codecov.io/gh/apache/airflow/pull/7615/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2RscC5weQ==) | `100% <100%> (ø)` | :arrow_up: |
   | [...s/google/cloud/example\_dags/example\_stackdriver.py](https://codecov.io/gh/apache/airflow/pull/7615/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3N0YWNrZHJpdmVyLnB5) | `100% <100%> (ø)` | :arrow_up: |
   | [...oviders/google/cloud/example\_dags/example\_tasks.py](https://codecov.io/gh/apache/airflow/pull/7615/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Rhc2tzLnB5) | `100% <100%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=footer). Last update [3f68eea...84e2e2f](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package
URL: https://github.com/apache/airflow/pull/7615#issuecomment-597063528
 
 
   I really love that we see all the refactors in "Prepare backport packages" :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7615: [AIRFLOW-6980] Improve system tests and building providers package
URL: https://github.com/apache/airflow/pull/7615#issuecomment-597050665
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=h1) Report
   > Merging [#7615](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3f68eea41c78552943fa48851db9d29f925eed7a?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7615/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7615      +/-   ##
   ==========================================
   - Coverage   86.95%   86.94%   -0.01%     
   ==========================================
     Files         900      900              
     Lines       43605    43605              
   ==========================================
   - Hits        37915    37911       -4     
   - Misses       5690     5694       +4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...providers/google/cloud/example\_dags/example\_dlp.py](https://codecov.io/gh/apache/airflow/pull/7615/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2RscC5weQ==) | `100% <100%> (ø)` | :arrow_up: |
   | [...s/google/cloud/example\_dags/example\_stackdriver.py](https://codecov.io/gh/apache/airflow/pull/7615/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3N0YWNrZHJpdmVyLnB5) | `100% <100%> (ø)` | :arrow_up: |
   | [...oviders/google/cloud/example\_dags/example\_tasks.py](https://codecov.io/gh/apache/airflow/pull/7615/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Rhc2tzLnB5) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7615/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.03% <0%> (-1.13%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=footer). Last update [3f68eea...84e2e2f](https://codecov.io/gh/apache/airflow/pull/7615?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services