You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/20 22:52:43 UTC
Re: Review Request 66162: Changed names related to
`DiskProfileAdaptor` for consistency.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66162/
-----------------------------------------------------------
(Updated March 20, 2018, 10:52 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Moved the changes related to `Flags` from the previous patch.
Summary (updated)
-----------------
Changed names related to `DiskProfileAdaptor` for consistency.
Repository: mesos
Description (updated)
-------
This patch makes name changes to make the code base consistent with the
finalized module name `DiskProfileAdaptor`. It also moves
`mesos::internal::storage::Flags` into the `UriDiskProfileAdaptor` class
since the flags are specific to this module.
Diffs (updated)
-----
src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7
src/resource_provider/storage/uri_disk_profile_adaptor.hpp 22e9d8bee0c82807c8b06ef65751496fcd880acf
src/resource_provider/storage/uri_disk_profile_adaptor.cpp 665798fdb085ea34f93bd287fe6f9ab29a265cbf
src/tests/disk_profile_tests.cpp 577ccfe9614009ba4178886c100de22ff12047b6
src/tests/storage_local_resource_provider_tests.cpp 264d42b57fe1a8ea04c1de0a10112878c7b45d39
Diff: https://reviews.apache.org/r/66162/diff/2/
Changes: https://reviews.apache.org/r/66162/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 66162: Changed names related to
`DiskProfileAdaptor` for consistency.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66162/#review199644
-----------------------------------------------------------
Ship it!
- Benjamin Bannier
On March 20, 2018, 11:52 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66162/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 11:52 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes name changes to make the code base consistent with the
> finalized module name `DiskProfileAdaptor`. It also moves
> `mesos::internal::storage::Flags` into the `UriDiskProfileAdaptor` class
> since the flags are specific to this module.
>
>
> Diffs
> -----
>
> src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 22e9d8bee0c82807c8b06ef65751496fcd880acf
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp 665798fdb085ea34f93bd287fe6f9ab29a265cbf
> src/tests/disk_profile_tests.cpp 577ccfe9614009ba4178886c100de22ff12047b6
> src/tests/storage_local_resource_provider_tests.cpp 264d42b57fe1a8ea04c1de0a10112878c7b45d39
>
>
> Diff: https://reviews.apache.org/r/66162/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>