[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #628: [WIP] Implement the project and the projectStrict in the transforms

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #628: [WIP] Implement the project and the projectStrict in the transforms
URL: https://github.com/apache/incubator-iceberg/pull/628#discussion_r347165237
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/transforms/Bucket.java
 ##########
 @@ -124,19 +127,43 @@ public String toString() {
     }
   }
 
+  @Override
+  public UnboundPredicate<Integer> project(String name, BoundSetPredicate<T> predicate) {
 
 Review comment:
   This PR made me realize that adding `BoundSetPredicate` not only required adding a new method to the `ExpressionVisitor`, but also required new methods here in the `Transform` API. Because of this, I think a better option is to refactor to make `BoundSetPredicate` extend `BoundPredicate`. I've implemented that in #650; please take a look at that PR since I think this one should depend on those changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org