You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/24 22:42:37 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
nytai opened a new pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@rusackas @mistercrunch @dpgaspar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.61%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.31% +4.61%
==========================================
Files 574 182 -392
Lines 30180 17728 -12452
Branches 3066 0 -3066
==========================================
- Hits 19828 12465 -7363
+ Misses 10168 5263 -4905
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `70.31% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.81% <0.00%> (-0.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.36% <0.00%> (-0.16%)` | :arrow_down: |
| ... and [386 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...0d748ae](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.49% +4.79%
==========================================
Files 574 182 -392
Lines 30180 17728 -12452
Branches 3066 0 -3066
==========================================
- Hits 19828 12498 -7330
+ Misses 10168 5230 -4938
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `70.49% <ø> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [...rontend/src/explore/components/AggregateOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZ2dyZWdhdGVPcHRpb24uanN4) | | |
| [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | | |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | | |
| [superset-frontend/src/visualizations/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2NvbnN0YW50cy5qcw==) | | |
| [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | | |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | | |
| ... and [380 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...1c2a8ab](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/527bee50513998f7f5fa4e04f07fcadb09847e6b&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
- Coverage 70.56% 70.49% -0.07%
==========================================
Files 581 182 -399
Lines 30316 17812 -12504
Branches 3096 0 -3096
==========================================
- Hits 21393 12557 -8836
+ Misses 8812 5255 -3557
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.49% <ø> (-0.16%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.81% <0.00%> (-0.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.88% <0.00%> (-0.19%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.37% <0.00%> (-0.14%)` | :arrow_down: |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [527bee5...d7c3123](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/527bee50513998f7f5fa4e04f07fcadb09847e6b&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `76.92%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 70.56% 70.62% +0.05%
==========================================
Files 581 582 +1
Lines 30316 30357 +41
Branches 3096 3102 +6
==========================================
+ Hits 21393 21439 +46
+ Misses 8812 8806 -6
- Partials 111 112 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <ø> (-0.11%)` | :arrow_down: |
| #javascript | `58.89% <76.92%> (+0.10%)` | :arrow_up: |
| #python | `70.72% <ø> (+0.06%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uLmpzeA==) | `88.88% <ø> (ø)` | |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <88.88%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [527bee5...d7c3123](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
- Coverage 65.69% 65.57% -0.12%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
- Hits 19828 19826 -2
- Misses 10168 10224 +56
+ Partials 184 182 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.31% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...4ed5b4c](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#discussion_r416324176
##########
File path: superset-frontend/src/components/ListView/ListViewStyles.less
##########
@@ -61,6 +64,10 @@
margin: 0 8px;
}
+ .table-row-selected {
+ background-color: @gray-bg;
Review comment:
Thanks for using the variable! 🥇
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
- Coverage 65.69% 65.68% -0.02%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
+ Hits 19828 19859 +31
- Misses 10168 10191 +23
+ Partials 184 182 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.49% <ø> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...4ed5b4c](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.83%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.53% +4.83%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
+ Hits 19828 21325 +1497
+ Misses 10168 8795 -1373
+ Partials 184 112 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.66% <ø> (?)` | |
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <0.00%> (ø)` | |
| ... and [159 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...e90674d](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **decrease** coverage by `1.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
- Coverage 65.69% 63.71% -1.99%
==========================================
Files 574 532 -42
Lines 30180 28897 -1283
Branches 3066 2758 -308
==========================================
- Hits 19828 18411 -1417
- Misses 10168 10292 +124
- Partials 184 194 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.83% <ø> (?)` | |
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0Lmpz) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
| ... and [271 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...d3cddcd](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/527bee50513998f7f5fa4e04f07fcadb09847e6b&el=desc) will **decrease** coverage by `4.76%`.
> The diff coverage is `76.92%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
- Coverage 70.56% 65.79% -4.77%
==========================================
Files 581 582 +1
Lines 30316 30357 +41
Branches 3096 3102 +6
==========================================
- Hits 21393 19974 -1419
- Misses 8812 10201 +1389
- Partials 111 182 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.89% <76.92%> (+0.10%)` | :arrow_up: |
| #python | `70.65% <ø> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uLmpzeA==) | `88.88% <ø> (ø)` | |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <88.88%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [152 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [527bee5...d7c3123](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 65.72% +0.02%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
+ Hits 19828 19871 +43
- Misses 10168 10179 +11
+ Partials 184 182 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <0.00%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...e90674d](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 65.72% +0.02%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
+ Hits 19828 19871 +43
- Misses 10168 10179 +11
+ Partials 184 182 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <0.00%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...e90674d](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **decrease** coverage by `1.64%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
- Coverage 65.69% 64.05% -1.65%
==========================================
Files 574 532 -42
Lines 30180 28897 -1283
Branches 3066 2758 -308
==========================================
- Hits 19828 18510 -1318
- Misses 10168 10204 +36
+ Partials 184 183 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.72% <ø> (?)` | |
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0Lmpz) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
| ... and [272 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...d3cddcd](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **decrease** coverage by `1.99%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
- Coverage 65.69% 63.70% -2.00%
==========================================
Files 574 532 -42
Lines 30180 28897 -1283
Branches 3066 2758 -308
==========================================
- Hits 19828 18410 -1418
- Misses 10168 10293 +125
- Partials 184 194 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.82% <ø> (?)` | |
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0Lmpz) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
| ... and [271 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...d3cddcd](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.53%`.
> The diff coverage is `83.52%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 64.03% 70.57% +6.53%
==========================================
Files 532 582 +50
Lines 28897 30259 +1362
Branches 2758 3078 +320
==========================================
+ Hits 18503 21354 +2851
+ Misses 10211 8793 -1418
+ Partials 183 112 -71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (ø)` | |
| #javascript | `58.86% <76.36%> (?)` | |
| #python | `70.62% <96.66%> (+0.05%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (ø)` | |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (ø)` | |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (ø)` | |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (ø)` | |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <90.00%> (-1.10%)` | :arrow_down: |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| ... and [190 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [5e4c291...893f038](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.62%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.32% +4.62%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
+ Hits 19828 21260 +1432
+ Misses 10168 8853 -1315
+ Partials 184 119 -65
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.84% <ø> (?)` | |
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <0.00%> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...4ed5b4c](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 65.72% +0.02%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
+ Hits 19828 19871 +43
- Misses 10168 10179 +11
+ Partials 184 182 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <0.00%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...e90674d](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.56% +4.86%
==========================================
Files 574 182 -392
Lines 30180 17728 -12452
Branches 3066 0 -3066
==========================================
- Hits 19828 12510 -7318
+ Misses 10168 5218 -4950
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | | |
| [...ntend/src/dashboard/components/FilterIndicator.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvci5qc3g=) | | |
| [...nd/src/dashboard/util/findTabIndexByComponentId.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRUYWJJbmRleEJ5Q29tcG9uZW50SWQuanM=) | | |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | | |
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | | |
| [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | | |
| [...end/src/dashboard/util/dashboardFiltersColorMap.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Rhc2hib2FyZEZpbHRlcnNDb2xvck1hcC5qcw==) | | |
| ... and [377 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...1c2a8ab](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.53% +4.83%
==========================================
Files 574 182 -392
Lines 30180 17728 -12452
Branches 3066 0 -3066
==========================================
- Hits 19828 12504 -7324
+ Misses 10168 5224 -4944
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `70.53% <ø> (-0.04%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==) | | |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | | |
| [...rontend/src/dashboard/util/componentIsResizable.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLmpz) | | |
| [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | | |
| [...ntend/src/dashboard/util/getRevertedFilterScope.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFJldmVydGVkRmlsdGVyU2NvcGUuanM=) | | |
| [...et-frontend/src/explore/controlPanels/sections.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9zZWN0aW9ucy5qc3g=) | | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | | |
| [superset-frontend/src/components/ErrorBoundary.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS5qc3g=) | | |
| ... and [378 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...d3cddcd](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#discussion_r416323137
##########
File path: superset-frontend/src/components/ExpandableList.tsx
##########
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { ReactNode, useState } from 'react';
+// @ts-ignore
+import { Button } from 'react-bootstrap';
+import { css } from '@emotion/core';
+
+interface Props {
+ items: string[] | ReactNode[];
+ display?: number;
+}
+
+function intersperse(arr: any[], sep: string | ReactNode) {
+ if (arr.length === 0) {
+ return [];
+ }
+
+ return arr.slice(1).reduce((xs, x) => xs.concat([sep, x]), [arr[0]]);
+}
+
+const ActionButton: React.FunctionComponent<{ onClick: () => void }> = ({
+ onClick,
+ children,
+}) => (
+ <Button
+ bsStyle="link"
+ css={css`
Review comment:
These little ad hoc css tweaks, in the long run, will make me nervous. At some point, we'll need to make the super-awesome `SupersetButton` that does everything we need it to with props, so we don't need to pepper overrides around the codebase. Not a big concern for this PR, but pointing out some hopes and dreams :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.82%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.52% +4.82%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
+ Hits 19828 21322 +1494
+ Misses 10168 8797 -1371
+ Partials 184 113 -71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.63% <ø> (?)` | |
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <0.00%> (ø)` | |
| ... and [159 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...4ed5b4c](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
- Coverage 65.69% 65.57% -0.12%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
- Hits 19828 19826 -2
- Misses 10168 10224 +56
+ Partials 184 182 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.31% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...e90674d](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.62%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.32% +4.62%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
+ Hits 19828 21260 +1432
+ Misses 10168 8853 -1315
+ Partials 184 119 -65
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.84% <ø> (?)` | |
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <0.00%> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...e90674d](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 65.72% +0.02%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
+ Hits 19828 19871 +43
- Misses 10168 10179 +11
+ Partials 184 182 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <0.00%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...4ed5b4c](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **decrease** coverage by `1.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
- Coverage 65.69% 64.03% -1.67%
==========================================
Files 574 532 -42
Lines 30180 28897 -1283
Branches 3066 2758 -308
==========================================
- Hits 19828 18503 -1325
- Misses 10168 10211 +43
+ Partials 184 183 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (?)` | |
| #javascript | `?` | |
| #python | `70.56% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0Lmpz) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
| ... and [272 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...d3cddcd](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#discussion_r416779005
##########
File path: superset-frontend/src/components/ExpandableList.tsx
##########
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { ReactNode, useState } from 'react';
+// @ts-ignore
+import { Button } from 'react-bootstrap';
+import { css } from '@emotion/core';
+
+interface Props {
+ items: string[] | ReactNode[];
+ display?: number;
+}
+
+function intersperse(arr: any[], sep: string | ReactNode) {
+ if (arr.length === 0) {
+ return [];
+ }
+
+ return arr.slice(1).reduce((xs, x) => xs.concat([sep, x]), [arr[0]]);
+}
+
+const ActionButton: React.FunctionComponent<{ onClick: () => void }> = ({
+ onClick,
+ children,
+}) => (
+ <Button
+ bsStyle="link"
+ css={css`
Review comment:
yea we need a `<Button as="Link"/>` or something similar. I'll move this to `src/components`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.49% +4.79%
==========================================
Files 574 182 -392
Lines 30180 17728 -12452
Branches 3066 0 -3066
==========================================
- Hits 19828 12498 -7330
+ Misses 10168 5230 -4938
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `70.49% <ø> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset-frontend/src/utils/reducerUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3JlZHVjZXJVdGlscy5qcw==) | | |
| [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | | |
| [...rc/explore/components/controls/CheckboxControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9DaGVja2JveENvbnRyb2wuanN4) | | |
| [superset-frontend/src/CRUD/CollectionTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLmpzeA==) | | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | | |
| ... and [380 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...0d748ae](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
- Coverage 65.69% 65.68% -0.02%
==========================================
Files 574 582 +8
Lines 30180 30232 +52
Branches 3066 3078 +12
==========================================
+ Hits 19828 19859 +31
- Misses 10168 10191 +23
+ Partials 184 182 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.86% <76.36%> (+0.09%)` | :arrow_up: |
| #python | `70.49% <ø> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `90.90% <ø> (-0.40%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.23% <14.28%> (+0.73%)` | :arrow_up: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `90.56% <33.33%> (+1.88%)` | :arrow_up: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.70% <60.00%> (+0.82%)` | :arrow_up: |
| [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `85.71% <85.71%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...4ed5b4c](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#discussion_r416326819
##########
File path: superset-frontend/src/components/SearchInput.tsx
##########
@@ -17,13 +17,95 @@
* under the License.
*/
import styled from '@superset-ui/style';
+import { css } from '@emotion/core';
+import React from 'react';
-export default styled.input`
- background-color: ${({ theme }) => theme.colors.secondary.light5};
+interface Props {
+ onSubmit: () => void;
+ onClear: () => void;
+ value: string;
+ onChange: React.EventHandler<React.ChangeEvent<HTMLInputElement>>;
+ placeholder?: string;
+}
+
+const StyledInput = styled.input`
+ width: 200px;
background-image: none;
border: 1px solid ${({ theme }) => theme.colors.secondary.light2};
border-radius: 4px;
box-shadow: inset 0 1px 1px rgba(0, 0, 0, 0.075);
- padding: 4px 8px;
+ padding: 4px 28px;
transition: border-color 0.15s ease-in-out, box-shadow 0.15s ease-in-out;
+ &:focus {
+ outline: none;
+ }
+`;
+
+const SearchIcon = styled.span`
+ position: absolute;
+ z-index: 2;
+ display: block;
+ width: 28px;
+ height: 28px;
+ text-align: center;
+ cursor: pointer;
+ background-position: 2px 2px;
+ background-image: url('/static/assets/images/icons/search.svg');
+ background-repeat: no-repeat;
`;
+
+const ClearIcon = styled.span`
+ position: absolute;
+ z-index: 2;
+ display: block;
+ width: 28px;
+ height: 28px;
+ text-align: center;
+ cursor: pointer;
+ right: 2px;
+ top: 1px;
+ background-position: 2px 2px;
+ background-image: url('/static/assets/images/icons/cancel-x.svg');
+ background-repeat: no-repeat;
+`;
+
+export default function SearchInput({
+ onSubmit,
+ onClear,
+ placeholder = 'Search',
+ value,
+ onChange,
+}: Props) {
+ return (
+ <div
+ css={css`
+ position: relative;
Review comment:
It's not relative by default? Kind of odd. I also wonder if this makes more sense here, or in the SASS of the `styled.span` above, as a direct descendant selector, `& > div {...}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.61%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.31% +4.61%
==========================================
Files 574 182 -392
Lines 30180 17728 -12452
Branches 3066 0 -3066
==========================================
- Hits 19828 12465 -7363
+ Misses 10168 5263 -4905
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `70.31% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.81% <0.00%> (-0.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.36% <0.00%> (-0.16%)` | :arrow_down: |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...4ed5b4c](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.61%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.31% +4.61%
==========================================
Files 574 182 -392
Lines 30180 17728 -12452
Branches 3066 0 -3066
==========================================
- Hits 19828 12465 -7363
+ Misses 10168 5263 -4905
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `70.31% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.81% <0.00%> (-0.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.36% <0.00%> (-0.16%)` | :arrow_down: |
| ... and [386 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...d3cddcd](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9651: [Chart & Dashboard] improve listview filter ui and add expandable list support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9651:
URL: https://github.com/apache/incubator-superset/pull/9651#issuecomment-619269877
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=h1) Report
> Merging [#9651](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/29dd9894838fccb014d870b07cf0a14e0919dd13&el=desc) will **increase** coverage by `4.61%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9651 +/- ##
==========================================
+ Coverage 65.69% 70.31% +4.61%
==========================================
Files 574 182 -392
Lines 30180 17728 -12452
Branches 3066 0 -3066
==========================================
- Hits 19828 12465 -7363
+ Misses 10168 5263 -4905
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `70.31% <ø> (-0.26%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `81.04% <ø> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.81% <0.00%> (-0.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.36% <0.00%> (-0.16%)` | :arrow_down: |
| ... and [386 more](https://codecov.io/gh/apache/incubator-superset/pull/9651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=footer). Last update [29dd989...d3cddcd](https://codecov.io/gh/apache/incubator-superset/pull/9651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org