You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Erick Erickson (Jira)" <ji...@apache.org> on 2020/05/01 17:20:00 UTC
[jira] [Resolved] (SOLR-10415) Within solr-core, debug/trace level
logging should use parameterized log messages
[ https://issues.apache.org/jira/browse/SOLR-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson resolved SOLR-10415.
-----------------------------------
Fix Version/s: 8.6
Resolution: Fixed
All the logging calls are either
1> parameterized
or
2> surrounded with "if (log.is*Enabled)" clauses and a validation check has been added to master/9x in Gradle.
> Within solr-core, debug/trace level logging should use parameterized log messages
> ---------------------------------------------------------------------------------
>
> Key: SOLR-10415
> URL: https://issues.apache.org/jira/browse/SOLR-10415
> Project: Solr
> Issue Type: Improvement
> Components: logging
> Reporter: Michael Braun
> Priority: Trivial
> Fix For: 8.6
>
>
> Noticed in several samplings of an active Solr that several debug statements were taking decently measurable time because of the time of the .toString even when the log.debug() statement would not output because it was effectively INFO or higher. Using parameterized logging statements, ie 'log.debug("Blah {}", o)' will avoid incurring that cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org