[GitHub] [spark] maropu commented on a change in pull request #27567: [SPARK-30822][SQL] Remove semicolon at the end of a sql query

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #27567: [SPARK-30822][SQL] Remove semicolon at the end of a sql query
URL: https://github.com/apache/spark/pull/27567#discussion_r388038797
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
 ##########
 @@ -45,7 +45,10 @@ class SparkSqlParser(conf: SQLConf) extends AbstractSqlParser(conf) {
   private val substitutor = new VariableSubstitution(conf)
 
   protected override def parse[T](command: String)(toResult: SqlBaseParser => T): T = {
-    super.parse(substitutor.substitute(command))(toResult)
+    val trimmed_command = if (command.trim.endsWith(";")) {
 
 Review comment:
   How about this new behaviour? That looks fine to me though. @cloud-fan @dongjoon-hyun @HyukjinKwon 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org