You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/27 21:24:28 UTC

[GitHub] [hadoop-ozone] vivekratnavel opened a new pull request #499: HDDS-2855. Recon getContainers API should return a maximum of 1000 co…

vivekratnavel opened a new pull request #499: HDDS-2855. Recon getContainers API should return a maximum of 1000 co…
URL: https://github.com/apache/hadoop-ozone/pull/499
 
 
   …ntainers by default.
   
   ## What changes were proposed in this pull request?
   
   Change the default limit of Recon API responses to 1000 items for any API request.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-2855
   
   ## How was this patch tested?
   
   I tested the patch by hitting the API - `http://localhost:9888/api/containers/1/keys` and `http://localhost:9888/api/containers` to check if the response defaults to 1000 items and it did.
   
   <img width="413" alt="Screen Shot 2020-01-27 at 1 21 46 PM" src="https://user-images.githubusercontent.com/1051198/73214958-06ed9a00-4108-11ea-90c3-09f446e68c84.png">
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek closed pull request #499: HDDS-2855. Recon getContainers API should return a maximum of 1000 co…

Posted by GitBox <gi...@apache.org>.
elek closed pull request #499: HDDS-2855. Recon getContainers API should return a maximum of 1000 co…
URL: https://github.com/apache/hadoop-ozone/pull/499
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #499: HDDS-2855. Recon getContainers API should return a maximum of 1000 co…

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #499: HDDS-2855. Recon getContainers API should return a maximum of 1000 co…
URL: https://github.com/apache/hadoop-ozone/pull/499#issuecomment-579410419
 
 
   Hi @elek 
   
   Thanks for committing this change. To answer your question, this patch just limits the number of items returned by default when there is no limit query param in the API request. Previously, when there is no limit specified, the API would return all the results. Now, the API returns just 1000 results by default. Once we support proper pagination, the UI will have page numbers listed at the bottom.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #499: HDDS-2855. Recon getContainers API should return a maximum of 1000 co…

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #499: HDDS-2855. Recon getContainers API should return a maximum of 1000 co…
URL: https://github.com/apache/hadoop-ozone/pull/499#issuecomment-578975113
 
 
   LGTM +1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #499: HDDS-2855. Recon getContainers API should return a maximum of 1000 co…

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #499: HDDS-2855. Recon getContainers API should return a maximum of 1000 co…
URL: https://github.com/apache/hadoop-ozone/pull/499#issuecomment-578960079
 
 
   @avijayanhwx @anuengineer Please review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org