You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "guptakushal03 (via GitHub)" <gi...@apache.org> on 2026/07/22 17:06:52 UTC
[PR] airflowctl: Fix datetime.datetime CLI parameter parsing [airflow]
guptakushal03 opened a new pull request, #70250:
URL: https://github.com/apache/airflow/pull/70250
Fixes `datetime.datetime`-typed CLI parameter parsing in `airflowctl`.
Previously, `datetime.datetime` parameters were mapped directly to the `datetime.datetime` constructor, causing valid ISO-8601 datetime strings (for example, `2026-07-01` and `2026-07-01T14:30:00`) to be rejected by `argparse`.
This change:
* Adds `iso_datetime_type()` to parse ISO-8601 datetime strings using `datetime.datetime.fromisoformat()`.
* Updates `datetime.datetime`-typed CLI arguments to use the parser instead of the bare constructor.
* Adds unit tests covering valid datetime inputs and invalid values that should raise `argparse.ArgumentTypeError`.
closes: #70232
---
##### Was generative AI tooling used to co-author this PR?
* [x] Yes (ChatGPT)
Generated-by: ChatGPT following the guidelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] airflowctl: Fix datetime.datetime CLI parameter parsing [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #70250:
URL: https://github.com/apache/airflow/pull/70250#issuecomment-5316578431
Thanks — and sorry to close it.
This overlaps #70249, opened the same day, which fixes the same `_python_type_from_string` type map. #70249 is the broader fix: it repairs both `datetime.date` and `datetime.datetime` (this PR covers only `datetime.datetime`, leaving date-typed parameters still broken), normalises the trailing `Z` the API actually emits, passes already-typed values through unchanged, and adds an end-to-end test that the generated `dagrun list --start-date` argument parses.
Going with #70249 so both halves land together rather than in two passes. It has changes requested outstanding, so it isn't finished either — but the shape is the one to build on.
Closing in its favour. The diagnosis was correct, and the `argparse.ArgumentTypeError` approach matches what #70249 landed on.
---
_Drafted by an AI assistant and may contain mistakes — if you think this call is wrong, say so and the PR will be reopened; a human maintainer has the final word._
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] airflowctl: Fix datetime.datetime CLI parameter parsing [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #70250:
URL: https://github.com/apache/airflow/pull/70250#issuecomment-5049127389
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] airflowctl: Fix datetime.datetime CLI parameter parsing [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #70250: airflowctl: Fix datetime.datetime CLI parameter parsing
URL: https://github.com/apache/airflow/pull/70250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org