You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/08/17 19:15:03 UTC

[PR] test(integration): add SIGKILL crash-durability cluster tests [iggy]

hubcio opened a new pull request, #3905:
URL: https://github.com/apache/iggy/pull/3905

   Every harness "crash" was a graceful SIGTERM with a 5s shutdown
   flush, so no test asserted that an acked write survives a real
   process kill at any node count, and the torn-tail recovery path
   in segment_recovery had no coverage at all.
   
   Add a kill() facility (SIGKILL with the watchdog stopped before
   the signal), shared disk oracles under harness::disk, and 12
   cluster tests covering crash durability, offset re-mint, on-disk
   corruption recovery, failover client continuity, and client-table
   dedup under churn. Six tests pass; seven are honest red specs
   marked #[ignore] with reasons naming the defects they pin:
   offset re-mint after restart, torn-tail size-counter divergence
   bricking restarts, index stride misalignment, missing SDK
   multi-endpoint failover, dedup-watermark eviction, reply-ring
   fall-off, and unknown operations collapsing into
   InvalidBitPattern.
   
   REPLY_RING_CAPACITY is exported from consensus so the reply-ring
   spec tracks the real constant instead of a copied literal.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(integration): add SIGKILL crash-durability cluster tests [iggy]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3905:
URL: https://github.com/apache/iggy/pull/3905#issuecomment-5319137940

   ## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3905?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 82.69%. Comparing base ([`1890c35`](https://app.codecov.io/gh/apache/iggy/commit/1890c35f3a0cdd7766d68eef0fc297d33941f505?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d0beb43`](https://app.codecov.io/gh/apache/iggy/commit/d0beb434ee0d3f45712feca8b562174dd8586826?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3905      +/-   ##
   ============================================
   - Coverage     83.14%   82.69%   -0.45%     
     Complexity     1340     1340              
   ============================================
     Files          1219     1217       -2     
     Lines        166113   165863     -250     
     Branches     134282   134235      -47     
   ============================================
   - Hits         138108   137162     -946     
   - Misses        24348    25041     +693     
   - Partials       3657     3660       +3     
   ```
   
   | [Components](https://app.codecov.io/gh/apache/iggy/pull/3905/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3905/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.69% <ø> (ø)` | |
   | [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3905/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.54% <ø> (ø)` | |
   | [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3905/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.31% <ø> (ø)` | |
   | [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3905/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.00% <ø> (ø)` | |
   | [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3905/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.48% <ø> (ø)` | |
   | [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3905/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.23% <ø> (-6.60%)` | :arrow_down: |
   | [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3905/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.04% <ø> (ø)` | |
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3905?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [core/consensus/src/client\_table.rs](https://app.codecov.io/gh/apache/iggy/pull/3905?src=pr&el=tree&filepath=core%2Fconsensus%2Fsrc%2Fclient_table.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25zZW5zdXMvc3JjL2NsaWVudF90YWJsZS5ycw==) | `88.84% <ø> (ø)` | |
   | [core/shard/src/router.rs](https://app.codecov.io/gh/apache/iggy/pull/3905?src=pr&el=tree&filepath=core%2Fshard%2Fsrc%2Frouter.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaGFyZC9zcmMvcm91dGVyLnJz) | `79.87% <ø> (ø)` | |
   
   ... and [56 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3905/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(integration): add SIGKILL crash-durability cluster tests [iggy]

Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #3905:
URL: https://github.com/apache/iggy/pull/3905


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org