[GitHub] [doris] yiguolei commented on a diff in pull request #16208: [improvement](metrics) Metrics add all rowset nums and segment nums

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #16208:
URL: https://github.com/apache/doris/pull/16208#discussion_r1089931406


##########
be/src/olap/tablet.h:
##########
@@ -550,6 +551,14 @@ inline Version Tablet::max_version() const {
     return _tablet_meta->max_version();
 }
 
+inline uint64_t Tablet::segment_count() const {
+    uint64_t segment_nums = 0;

Review Comment:
   need read lock?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org