[GitHub] [daffodil-vscode] nlewis05 opened a new issue, #622: TDML configuration causing server timeout issue when running from launch.json

["nlewis05 (via GitHub)" <gi...@apache.org>]

nlewis05 opened a new issue, #622:
URL: https://github.com/apache/daffodil-vscode/issues/622

   With the following configuration:
   ``` 
   "tdmlConfig": {
    "action": "none",
    "name": "${command:AskForTDMLName}",
    "description": "${command:AskForTDMLDescription}",
    "path": "${command:AskForTDMLPath}" },
   ```
   
   The debugger is continuing to ask for TDML configurations even when the action is "none"
   ![image](https://user-images.githubusercontent.com/131286323/236509303-7a0ef691-ca19-4265-a197-7c429192a253.png)
   
   If the configuration are not given within a time limit, the debugger will terminate and crash.
   
   ![image](https://user-images.githubusercontent.com/131286323/236509451-9e16e5ce-1134-405c-8a8e-a6413106dcf5.png)
   
   When this configuration was used:
   ```
              "tdmlConfig": {
                   "action": "none",
                   "name": "tdml1",
                   "description": "tdml1",
                   "path": "${workspaceFolder}/target/foo.tdml"
               },
   ```
   The debugger will continue to run and not ask for the TDML configurations because they are already provided.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] Shanedell closed issue #622: TDML configuration causing server timeout issue when running from launch.json

["Shanedell (via GitHub)" <gi...@apache.org>]

Shanedell closed issue #622: TDML configuration causing server timeout issue when running from launch.json
URL: https://github.com/apache/daffodil-vscode/issues/622


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] Shanedell commented on issue #622: TDML configuration causing server timeout issue when running from launch.json

["Shanedell (via GitHub)" <gi...@apache.org>]

Shanedell commented on issue #622:
URL: https://github.com/apache/daffodil-vscode/issues/622#issuecomment-1542778256

   I believe the fix for this is adding an else to if that checks for certain actions eg:
   
   ```ts
   if (
       config?.tdmlConfig?.action === 'generate' ||
       config?.tdmlConfig?.action === 'append' ||
       config?.tdmlConfig?.action === 'execute'
   ) {
       ...
   } else {
       // either action is 'none' or bad action provided don't prompt
       config.tdmlConfig.name = ''
       config.tdmlConfig.description = ''
       config.tdmlConfig.path = '' 
   }
   ```
   
   This will make sure when the action is 'none' or not a good action the user won't get prompted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org