You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2015/07/09 16:48:12 UTC

Review Request 36354: HIVE-10882

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36354/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-10882
    https://issues.apache.org/jira/browse/HIVE-10882


Repository: hive-git


Description
-------

CBO: Calcite Operator To Hive Operator (Calcite Return Path) empty filtersMap of join operator causes wrong results


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java 9ebb24ffc33c49b0d1479b17af99bba78ca4c5fc 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveJoin.java 668960ec18a4ed8a40b4e08bc814f6ca14b13fd3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java 911cedaccc1051a0b0dff56cee0c5758120fb139 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveSemiJoin.java dd1691c7482128bed15608b03df84eb20d4b06e6 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java c5e0e1153341218fa36bd3de2155d17478a17436 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java f72f67fec787ff8db729f998a96b1264bc6cf8cb 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 84c6cc8b0e89dafc4cbbc9e6c337c3215d10ddbb 
  ql/src/test/queries/clientpositive/fouter_join_ppr.q PRE-CREATION 
  ql/src/test/results/clientpositive/fouter_join_ppr.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/36354/diff/


Testing
-------

Existing tests + new test added with return path on.


Thanks,

Jesús Camacho Rodríguez


Re: Review Request 36354: HIVE-10882

Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36354/
-----------------------------------------------------------

(Updated July 13, 2015, 5:04 p.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-10882
    https://issues.apache.org/jira/browse/HIVE-10882


Repository: hive-git


Description
-------

CBO: Calcite Operator To Hive Operator (Calcite Return Path) empty filtersMap of join operator causes wrong results


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java ab793f1acdecadc1fd6c2f8508d1d6f2a74e931d 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveJoin.java 6814df60a2ad93cef3a52c498630aa879bc0ff34 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java 7a43f293808e689d70244f7fae5a9baf4b58606a 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveSemiJoin.java dd1691c7482128bed15608b03df84eb20d4b06e6 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java a0144f3915d540728ca5be8af6299c4d828b1b42 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java f72f67fec787ff8db729f998a96b1264bc6cf8cb 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 86ac4d12ae154b859824f97cedce39a639cdef59 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 3b5dbe26982eb97fff99bd36332b14e97de01c40 
  ql/src/test/queries/clientpositive/fouter_join_ppr.q PRE-CREATION 
  ql/src/test/results/clientpositive/fouter_join_ppr.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/36354/diff/


Testing
-------

Existing tests + new test added with return path on.


Thanks,

Jesús Camacho Rodríguez