[GitHub] srowen commented on issue #23925: [SPARK-27016][SQL][BUILD] Treat all antlr warnings as errors while generating parser from the sql grammar file.

[GitBox <gi...@apache.org>]

srowen commented on issue #23925: [SPARK-27016][SQL][BUILD] Treat all antlr warnings as errors while generating parser from the sql grammar file.
URL: https://github.com/apache/spark/pull/23925#issuecomment-468457721
 
 
   Hm, I'm not sure. SBT 'reads' the pom file via a plugin, but I think the translation is imperfect. I'm still surprised. Sometimes we've worked around it by duplicating the config and hacking it into the SBT build. I'm not sure how to do it here.
   
   We use Maven (also) in the test jobs that aren't PR builders, so this would still get caught eventually, and I presume is a pretty rare thing to update the schemas. We might just live with it unless someone has a better idea.
   
   (Also, I wonder if we should make the PR builders use Maven, as it's the build of record really)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org