You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/30 15:02:29 UTC
[GitHub] [incubator-pekko-connectors] pjfanning opened a new pull request, #128: Scala3 couchbase support
pjfanning opened a new pull request, #128:
URL: https://github.com/apache/incubator-pekko-connectors/pull/128
* play-json is just a test dependency so seems ok to use an RC jar (no non-RC jar supports Scala 3)
* still fails to compile - 2 exceptions like this:
```
[error] -- [E007] Type Mismatch Error: /Users/pj.fanning/code/incubator-pekko-connectors/couchbase/src/main/scala/org/apache/pekko/stream/connectors/couchbase/scaladsl/CouchbaseFlow.scala:118:27
[error] 104 | Flow
[error] 105 | .fromMaterializer { (materializer, _) =>
[error] 106 | val session = CouchbaseSessionRegistry(materializer.system).sessionFor(sessionSettings, bucketName)
[error] 107 | Flow[T]
[error] 108 | .mapAsync(writeSettings.parallelism)(doc => {
[error] 109 | implicit val executor: ExecutionContext = materializer.system.dispatcher
[error] 110 | session
[error] 111 | .flatMap(_.upsertDoc(doc, writeSettings))
[error] 112 | .map(_ => CouchbaseWriteSuccess(doc))
[error] 113 | .recover {
[error] 114 | case exception => CouchbaseWriteFailure(doc, exception)
[error] 115 | }
[error] 116 | })
[error] 117 | }
[error] 118 | .mapMaterializedValue(_ => NotUsed)
[error] | ^
[error] |Found: org.apache.pekko.stream.scaladsl.Flow[T,
[error] | org.apache.pekko.stream.connectors.couchbase.CouchbaseWriteResult[? >: T <: T]
[error] | ,
[error] |concurrent.Future[org.apache.pekko.NotUsed]]#ReprMat[
[error] | org.apache.pekko.stream.connectors.couchbase.CouchbaseWriteResult[? >: T <: T]
[error] | ,
[error] |org.apache.pekko.NotUsed.type]
[error] |Required: org.apache.pekko.stream.scaladsl.Flow[T,
[error] | org.apache.pekko.stream.connectors.couchbase.CouchbaseWriteResult[T],
[error] | org.apache.pekko.NotUsed]
[error] |
[error] |where: T is a type in method upsertDocWithResult with bounds <: com.couchbase².client.java.document.Document[?]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #128: Scala3 couchbase support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #128:
URL: https://github.com/apache/incubator-pekko-connectors/pull/128#discussion_r1210734923
##########
project/Dependencies.scala:
##########
@@ -129,10 +129,9 @@ object Dependencies {
"com.couchbase.client" % "java-client" % CouchbaseVersion, // ApacheV2
"io.reactivex" % "rxjava-reactive-streams" % "1.2.1", // ApacheV2
"org.apache.pekko" %% "pekko-discovery" % PekkoVersion % Provided, // Apache V2
+ "org.apache.pekko" %% "pekko-http" % PekkoHttpVersion % Test, // Apache V2
"com.fasterxml.jackson.core" % "jackson-databind" % JacksonDatabindVersion % Test, // Apache V2
- "com.fasterxml.jackson.module" %% "jackson-module-scala" % JacksonDatabindVersion % Test, // Apache V2
- "com.typesafe.play" %% "play-json" % "2.10.0-RC8" % Test, // Apache V2
Review Comment:
Im guessing these were accidentally left in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning merged pull request #128: Scala3 couchbase support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #128:
URL: https://github.com/apache/incubator-pekko-connectors/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #128: Scala3 couchbase support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #128:
URL: https://github.com/apache/incubator-pekko-connectors/pull/128#discussion_r1210757584
##########
project/Dependencies.scala:
##########
@@ -129,10 +129,9 @@ object Dependencies {
"com.couchbase.client" % "java-client" % CouchbaseVersion, // ApacheV2
"io.reactivex" % "rxjava-reactive-streams" % "1.2.1", // ApacheV2
"org.apache.pekko" %% "pekko-discovery" % PekkoVersion % Provided, // Apache V2
+ "org.apache.pekko" %% "pekko-http" % PekkoHttpVersion % Test, // Apache V2
"com.fasterxml.jackson.core" % "jackson-databind" % JacksonDatabindVersion % Test, // Apache V2
- "com.fasterxml.jackson.module" %% "jackson-module-scala" % JacksonDatabindVersion % Test, // Apache V2
- "com.typesafe.play" %% "play-json" % "2.10.0-RC8" % Test, // Apache V2
Review Comment:
sure - I've already removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org