You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/20 01:30:58 UTC

[GitHub] [orc] czxrrr opened a new pull request #282: ORC-377: [c++] Add SnappyCompressionStream

czxrrr opened a new pull request #282:
URL: https://github.com/apache/orc/pull/282


   Currently ORC C++ only support writing with Zlib compression
   This branch aims to add support for Snappy compression


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] mathyingzhou edited a comment on pull request #282: ORC-377: [c++] Add SnappyCompressionStream

Posted by GitBox <gi...@apache.org>.
mathyingzhou edited a comment on pull request #282:
URL: https://github.com/apache/orc/pull/282#issuecomment-714842248


   Can we reopen the pull request? We are interested in adding the tests and getting it into ORC since the Arrow2ORC binder I’m developing now won’t be used that much if Snappy write is not supported in the ORC C++ lib.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] pgaref commented on pull request #282: ORC-377: [c++] Add SnappyCompressionStream

Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #282:
URL: https://github.com/apache/orc/pull/282#issuecomment-757518657


   Hey @majetideepak thanks for taking this up! 
   Looks that this has been inactive for a while, feel free to open a new PR 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] mathyingzhou commented on pull request #282: ORC-377: [c++] Add SnappyCompressionStream

Posted by GitBox <gi...@apache.org>.
mathyingzhou commented on pull request #282:
URL: https://github.com/apache/orc/pull/282#issuecomment-855453020


   @noirello Sure! I have three more Arrow issues to cover before I can work on this. It will be nice if you can do it this month. Otherwise I will.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] mathyingzhou commented on pull request #282: ORC-377: [c++] Add SnappyCompressionStream

Posted by GitBox <gi...@apache.org>.
mathyingzhou commented on pull request #282:
URL: https://github.com/apache/orc/pull/282#issuecomment-757512354


   Now I have time to work on that since I have finished the C++/Python ORC writer in Arrow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] pgaref closed pull request #282: ORC-377: [c++] Add SnappyCompressionStream

Posted by GitBox <gi...@apache.org>.
pgaref closed pull request #282:
URL: https://github.com/apache/orc/pull/282


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] mathyingzhou commented on pull request #282: ORC-377: [c++] Add SnappyCompressionStream

Posted by GitBox <gi...@apache.org>.
mathyingzhou commented on pull request #282:
URL: https://github.com/apache/orc/pull/282#issuecomment-714842248


   Can we reopen the pull request? We are interested in adding the tests and getting it into ORC since my ongoing Arrow2ORC binder won’t be used that much if Snappy write is not supported in the ORC C++ lib.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] majetideepak commented on pull request #282: ORC-377: [c++] Add SnappyCompressionStream

Posted by GitBox <gi...@apache.org>.
majetideepak commented on pull request #282:
URL: https://github.com/apache/orc/pull/282#issuecomment-763261799


   @mathyingzhou feel free to re-open this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] noirello commented on pull request #282: ORC-377: [c++] Add SnappyCompressionStream

Posted by GitBox <gi...@apache.org>.
noirello commented on pull request #282:
URL: https://github.com/apache/orc/pull/282#issuecomment-850906708


   This PR is dormant for a while now. I could open a new one for adding Snappy compression, if it's okay with everyone.
   The task looks very similar to the LZ4 compression that I created recently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org