You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/06 14:39:06 UTC
[GitHub] [spark] ulysses-you opened a new pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
ulysses-you opened a new pull request #29013:
URL: https://github.com/apache/spark/pull/29013
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Modify `OptimizeIn`, extract In convertible part if it is not convertible.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Try to find more predicate to push down.
First split `In` to 2 parts, one is convertible the other is not convertible. Then we can push down the convertible part.
A table `create table t1 (c1 int, c2 int) using parquet`
Before this pr
`select * from t1 where c1 in (1, 2, c2)` has no pushdown filter.
After this pr
`select * from t1 where c1 in (1, 2, c2)` has `In(c1, Seq(Literal(1), Literal(2)))` pushdown filter.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Add ut.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #29013:
URL: https://github.com/apache/spark/pull/29013#discussion_r450541986
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeInSuite.scala
##########
@@ -91,21 +91,6 @@ class OptimizeInSuite extends PlanTest {
comparePlans(optimized, correctAnswer)
}
- test("OptimizedIn test: In clause not optimized in case filter has attributes") {
Review comment:
Remove this test since we support convert part of list and new test include this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654600615
**[Test build #125148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125148/testReport)** for PR 29013 at commit [`0d982d2`](https://github.com/apache/spark/commit/0d982d2ebb5fd04d581b3a38e329d38988485659).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-655331190
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-655284605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654525564
**[Test build #125148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125148/testReport)** for PR 29013 at commit [`0d982d2`](https://github.com/apache/spark/commit/0d982d2ebb5fd04d581b3a38e329d38988485659).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654601326
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125148/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-713224018
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654292542
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-657157242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654574167
**[Test build #125158 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125158/testReport)** for PR 29013 at commit [`f45d6c3`](https://github.com/apache/spark/commit/f45d6c31f8d4b840e212dd0561d97ba96e13b458).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654601318
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654552528
**[Test build #125158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125158/testReport)** for PR 29013 at commit [`f45d6c3`](https://github.com/apache/spark/commit/f45d6c31f8d4b840e212dd0561d97ba96e13b458).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654525948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-657179699
**[Test build #125700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125700/testReport)** for PR 29013 at commit [`21c5262`](https://github.com/apache/spark/commit/21c5262e7025a7e1453c1aeaa901ada0781e875d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654574388
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-655362149
Why is ` where c1 in (1, 2) or c1 in (c2)` an optimized form? You mean it is fater than `where c1 in (1, 2, c2)`? At least, I think you need to describe more in the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654525948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654601318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-655330667
**[Test build #125299 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125299/testReport)** for PR 29013 at commit [`9bf23cc`](https://github.com/apache/spark/commit/9bf23cc95e1a58044ce5c4e41348f93d99c705a6).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654552837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654550847
I make a mistake, it should be
```
select * from t1 where c1 in (1, 2, c2)
||
\/
select * from t1 where c1 in (1, 2) or c1 in (c2)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #29013:
URL: https://github.com/apache/spark/pull/29013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654292483
**[Test build #125092 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125092/testReport)** for PR 29013 at commit [`bbf63c9`](https://github.com/apache/spark/commit/bbf63c91b614dae1c97cb20fb58b497ffe2c72f3).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-657157955
**[Test build #125700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125700/testReport)** for PR 29013 at commit [`21c5262`](https://github.com/apache/spark/commit/21c5262e7025a7e1453c1aeaa901ada0781e875d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-657157955
**[Test build #125700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125700/testReport)** for PR 29013 at commit [`21c5262`](https://github.com/apache/spark/commit/21c5262e7025a7e1453c1aeaa901ada0781e875d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654281664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-655284188
**[Test build #125299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125299/testReport)** for PR 29013 at commit [`9bf23cc`](https://github.com/apache/spark/commit/9bf23cc95e1a58044ce5c4e41348f93d99c705a6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654542265
I don't look into the impl. though (I just read the PR description), you meant this case? Or, do I miss something?
```
scala> sql("select * from t1").show()
+---+---+
| c1| c2|
+---+---+
| 1| 3|
| 3| 3|
+---+---+
scala> sql("select * from t1 where c1 in (1, 2, c2)").show()
+---+---+
| c1| c2|
+---+---+
| 1| 3|
| 3| 3|
+---+---+
scala> sql("select * from (select * from t1 where c1 in (1, 2)) t2(c1, c2) where t2.c1 in (1, 2, t2.c2)").show()
+---+---+
| c1| c2|
+---+---+
| 1| 3|
+---+---+
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-655284188
**[Test build #125299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125299/testReport)** for PR 29013 at commit [`9bf23cc`](https://github.com/apache/spark/commit/9bf23cc95e1a58044ce5c4e41348f93d99c705a6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-657179793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654574399
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125158/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654525564
**[Test build #125148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125148/testReport)** for PR 29013 at commit [`0d982d2`](https://github.com/apache/spark/commit/0d982d2ebb5fd04d581b3a38e329d38988485659).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654552528
**[Test build #125158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125158/testReport)** for PR 29013 at commit [`f45d6c3`](https://github.com/apache/spark/commit/f45d6c31f8d4b840e212dd0561d97ba96e13b458).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654550231
But, I think `select * from t1 where c1 in (1, 2, c2)` is equal to `select * from t1 where c1=1 or c1=2 or c1=c2`. Why can we transform it into `where c1 in (1, 2) and c1 in (c2)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654280952
**[Test build #125092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125092/testReport)** for PR 29013 at commit [`bbf63c9`](https://github.com/apache/spark/commit/bbf63c91b614dae1c97cb20fb58b497ffe2c72f3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-657157242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-655331190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654281664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-655396900
@maropu Once we have `where c1 in (1, 2) or c1 in (c2)`, we can optimize the `c1 in (1, 2)` part with `OptimizeIn`.
e.g.
```
c1 in(1, c2) => c1 = 1 or c1 in(c2)
c1 in(1, 2, ..., c2) => c1 inset(1, 2, ...) or c1 in (c2)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654574388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-655331199
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125299/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654280952
**[Test build #125092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125092/testReport)** for PR 29013 at commit [`bbf63c9`](https://github.com/apache/spark/commit/bbf63c91b614dae1c97cb20fb58b497ffe2c72f3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654292555
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125092/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-655284605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654292542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654546537
ah morning @maropu
As your case after this pr, it changes to:
```
select * from t1 where c1 in (1, 2, c2)
||
\/
select * from t1 where c1 in (1, 2) and c1 in (c2)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-654552837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29013: [SPARK-32196][SQL] Extract In convertible part if it is not convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29013:
URL: https://github.com/apache/spark/pull/29013#issuecomment-657179793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org