You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Dimuthu Gamage (JIRA)" <ji...@apache.org> on 2007/12/08 06:01:48 UTC

[jira] Commented: (AXIS2C-778) Generated stubs do not check status returned by response deserialize methods

    [ https://issues.apache.org/jira/browse/AXIS2C-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549648 ] 

Dimuthu Gamage commented on AXIS2C-778:
---------------------------------------

Fixed after Axis2/Java commit 602320

> Generated stubs do not check status returned by response deserialize methods
> ----------------------------------------------------------------------------
>
>                 Key: AXIS2C-778
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-778
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: code generation
>            Reporter: Michael Mole
>
> The generated client stubs do not check the status returned by the response deserialize methods.  Therefore there is no way to tell whether the deserialize was successful.
> For example, here is an excerpt from one of the stub methods from the Calculator example.
>             op_qname = axutil_qname_create(env,
>                                         "add" ,
>                                         "http://localhost/axis/Calculator",
>                                         NULL);
>             ret_node =  axis2_svc_client_send_receive_with_op_qname( svc_client, env, op_qname, payload);
>  
>             if (!is_soap_act_set)
>             {
>               
>               axis2_options_set_soap_action(options, env, NULL);    
>               
>               axis2_options_set_action( options, env, NULL);
>             }
>             
>                     if ( NULL == ret_node )
>                     {
>                         return NULL;
>                     }
>                     ret_val = adb_addResponse_create(env);
>                     adb_addResponse_deserialize(ret_val, env, ret_node );  /////////// return status is not handled here
>                     return ret_val;
>                 
>         }
> If adb_addResponse_deserialize fails, there should be some way of notifying the caller.  Perhaps the function should try to free the ret_val and return NULL.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org