You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/12/28 00:53:12 UTC
[kudu-CR] [gradle] Increase test JVMs heap size
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12134
Change subject: [gradle] Increase test JVMs heap size
......................................................................
[gradle] Increase test JVMs heap size
The flume test RegexpKuduOperationsProducerParseErrorTest is flaky and
throws OutOfMemoryError. As the default heap size for test task is 512m
[1], this commit increases the maximum java heap size to 1g to avoid
such error.
[1]: https://docs.gradle.org/current/userguide/build_environment.html#sec:configuring_jvm_memory
Change-Id: Iae86fe493a1fdc337d5ca8615b043b437a2a116d
---
M java/gradle/tests.gradle
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/12134/1
--
To view, visit http://gerrit.cloudera.org:8080/12134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae86fe493a1fdc337d5ca8615b043b437a2a116d
Gerrit-Change-Number: 12134
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [gradle] Increase test JVMs heap size
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12134 )
Change subject: [gradle] Increase test JVMs heap size
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae86fe493a1fdc337d5ca8615b043b437a2a116d
Gerrit-Change-Number: 12134
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 29 Jan 2019 20:50:12 +0000
Gerrit-HasComments: No
[kudu-CR] [gradle] Increase test JVMs heap size
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12134 )
Change subject: [gradle] Increase test JVMs heap size
......................................................................
[gradle] Increase test JVMs heap size
The flume test RegexpKuduOperationsProducerParseErrorTest is flaky and
throws OutOfMemoryError. As the default heap size for test task is 512m
[1], this commit increases the maximum java heap size to 1g to avoid
such error.
[1]: https://docs.gradle.org/current/userguide/build_environment.html#sec:configuring_jvm_memory
Change-Id: Iae86fe493a1fdc337d5ca8615b043b437a2a116d
Reviewed-on: http://gerrit.cloudera.org:8080/12134
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/gradle/tests.gradle
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae86fe493a1fdc337d5ca8615b043b437a2a116d
Gerrit-Change-Number: 12134
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [gradle] Increase test JVMs heap size
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12134 )
Change subject: [gradle] Increase test JVMs heap size
......................................................................
Patch Set 1: Code-Review+2
Looks OK to me but would be nice if Grant took a look too.
--
To view, visit http://gerrit.cloudera.org:8080/12134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae86fe493a1fdc337d5ca8615b043b437a2a116d
Gerrit-Change-Number: 12134
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Jan 2019 18:29:21 +0000
Gerrit-HasComments: No
[kudu-CR] [gradle] Increase test JVMs heap size
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12134 )
Change subject: [gradle] Increase test JVMs heap size
......................................................................
Patch Set 1:
I am okay with this.
Though, I would like to understand why the memory usage for these tests are so high. It would be nice if we could make the test more efficient in place of raising the limit for all tests.
Just looking at the code, I suspect it could be the use of the CapturingLogAppender. It captures all logged events of any level in a StringBuilder. Perhaps adding a filter so that only events above a certain level are captured would solve the problem and make the test more efficient/accurate.
--
To view, visit http://gerrit.cloudera.org:8080/12134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae86fe493a1fdc337d5ca8615b043b437a2a116d
Gerrit-Change-Number: 12134
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Jan 2019 01:48:23 +0000
Gerrit-HasComments: No
[kudu-CR] [gradle] Increase test JVMs heap size
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12134 )
Change subject: [gradle] Increase test JVMs heap size
......................................................................
Patch Set 1:
> I am okay with this.
>
> Though, I would like to understand why the memory usage for these
> tests are so high. It would be nice if we could make the test more
> efficient in place of raising the limit for all tests.
>
> Just looking at the code, I suspect it could be the use of the
> CapturingLogAppender. It captures all logged events of any level in
> a StringBuilder. Perhaps adding a filter so that only events above
> a certain level are captured would solve the problem and make the
> test more efficient/accurate.
I agree we should figure out the root cause of high memory usage. Although, I think we can have this patch first to de-flake the test (I noticed this test has become flaky after we switched to Gradle in some environment which has set the maximum java heap size to 1g for Maven). And do a follow up for improve the memory usage.
--
To view, visit http://gerrit.cloudera.org:8080/12134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae86fe493a1fdc337d5ca8615b043b437a2a116d
Gerrit-Change-Number: 12134
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 29 Jan 2019 00:36:03 +0000
Gerrit-HasComments: No