[GitHub] [spark] yaooqinn commented on a change in pull request #32781: [SPARK-35650][SQL] Enhance `RepartitionByExpression` to make it coalesce partitions efficiently by AQE

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #32781:
URL: https://github.com/apache/spark/pull/32781#discussion_r647582632



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -92,6 +92,11 @@ case object REPARTITION extends ShuffleOrigin
 // a certain partition number. Spark can't optimize it.
 case object REPARTITION_WITH_NUM extends ShuffleOrigin
 
+// Indicates that the shuffle operator was added by the user-specified repartition operator.
+// Spark first tries to coalesce partitions, if it cannot be coalesced, then try to use the
+// local shuffle reader.
+case object REPARTITION_WITHOUT_COL_AND_NUM extends ShuffleOrigin

Review comment:
       Are we use `_WITH_XXX` to indicate the point from which shuffle starts?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org