You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2020/05/25 15:03:55 UTC
[tomcat] branch 8.5.x updated: 64470: Fix solidus handling
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 1bbe971 64470: Fix solidus handling
1bbe971 is described below
commit 1bbe9714d263c630dd45155c928f7b0293372b0f
Author: remm <re...@apache.org>
AuthorDate: Mon May 25 16:59:41 2020 +0200
64470: Fix solidus handling
It should reflect the UDecoder.ALLOW_ENCODED_SLASH system property.
---
java/org/apache/catalina/connector/Connector.java | 4 +++-
webapps/docs/changelog.xml | 4 ++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/connector/Connector.java b/java/org/apache/catalina/connector/Connector.java
index 2dc4119..d7ee351 100644
--- a/java/org/apache/catalina/connector/Connector.java
+++ b/java/org/apache/catalina/connector/Connector.java
@@ -43,6 +43,7 @@ import org.apache.tomcat.util.IntrospectionUtils;
import org.apache.tomcat.util.buf.B2CConverter;
import org.apache.tomcat.util.buf.CharsetUtil;
import org.apache.tomcat.util.buf.EncodedSolidusHandling;
+import org.apache.tomcat.util.buf.UDecoder;
import org.apache.tomcat.util.net.SSLHostConfig;
import org.apache.tomcat.util.net.openssl.OpenSSLImplementation;
import org.apache.tomcat.util.res.StringManager;
@@ -285,7 +286,8 @@ public class Connector extends LifecycleMBeanBase {
/**
* The behavior when an encoded solidus (slash) is submitted.
*/
- private EncodedSolidusHandling encodedSolidusHandling = EncodedSolidusHandling.REJECT;
+ private EncodedSolidusHandling encodedSolidusHandling =
+ UDecoder.ALLOW_ENCODED_SLASH ? EncodedSolidusHandling.DECODE : EncodedSolidusHandling.REJECT;
/**
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index f16ad87..66faa8b 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -56,6 +56,10 @@
Add the special internal rewrite maps for case modification and
escaping. (remm/fschumacher)
</update>
+ <fix>
+ <bug>64470</bug>: The default value of the solidus handling should
+ reflect the associated system property. (remm)
+ </fix>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org