You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/03 08:03:24 UTC

[GitHub] [pulsar] mattisonchao opened a new pull request #15011: [improve][transaction] support configurable ``transactionBufferClientOperationTimeoutInMills``

mattisonchao opened a new pull request #15011:
URL: https://github.com/apache/pulsar/pull/15011


   ### Motivation
   
   Current ``operationTimeoutInMills`` configuration in ``TransactionBufferHandlerImpl`` is not configurable. we can change it to configurable.
   
   ### Modifications
   
   - Make ``operationTimeoutInMills`` configurable.
   - The default ``transactionBufferClientOperationTimeoutInMills`` is 3000.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - The default values of configurations: (yes)
   
   ### Documentation
   
   - [x] `doc-required` 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on a change in pull request #15011: [improve][transaction] support configurable ``transactionBufferClientOperationTimeoutInMills``

Posted by GitBox <gi...@apache.org>.
HQebupt commented on a change in pull request #15011:
URL: https://github.com/apache/pulsar/pull/15011#discussion_r841187704



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2475,6 +2475,12 @@
     )
     private int transactionBufferClientMaxConcurrentRequests = 1000;
 
+    @FieldContext(
+            category = CATEGORY_TRANSACTION,
+            doc = "The transaction buffer client's operation timeout in milliseconds."
+    )
+    private long transactionBufferClientOperationTimeoutInMills = 3000;

Review comment:
       It's better to write in this way: `long transactionBufferClientOperationTimeoutInMills = 3000L;` or `int transactionBufferClientOperationTimeoutInMills = 3000;`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org